Fix missing aggregation separators, add patches Django app#6115
Merged
Conversation
patches Django app
grantfitzsimmons
marked this pull request as ready for review
January 17, 2025 19:03
lexiclevenger
approved these changes
Jan 21, 2025
Collaborator
There was a problem hiding this comment.
- Verify that all separators are cleared in
v7.9.6.2in aDataObjFormattersapp resource - Pull this PR and run the migration
- Verify that all empty separators have been restored to default
Looks good! All empty separators are restored.
This branch also makes aggregators appear in the visual editor menu that weren't previously hidden without enabling 'Show All Tables' (mostly Attachment tables). I think all of these tables have default aggregators, so it's probably not a problem unless they really need to be hidden.
Triggered by a0c1fdf on branch refs/heads/issue-5154-patch
CarolineDenis
approved these changes
Mar 10, 2025
Triggered by 746f54c on branch refs/heads/issue-5154-patch
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-10-2-release-announcement/2455/1 |
9 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Warning
This PR affects database migrations. See migration testing instructions.
Fixes #5154, but retroactively, since this has already led to a lot of issues since the bug was introduced, and now its been insidiously spreading since (reported by numerous users, just solved another case today so I figured I should solve all of them at once).
This also creates a
patchesDjango app that we can add to in the future when needing to do something like this.It runs this on all databases:
You cannot set the separator to nothing (
""), so we can be very confident this solves cases where the default was lost and does not break cases where it is not desired.Checklist
self-explanatory (or properly documented)
Testing instructions
Before using this branch, switch to
v7.9.6.2and edit the separator for any table aggregation.Once you do, all default separators for table aggregations will be set to
""rather than"; ". This leads to very undesirable results where all Preparations or Collectors are aggregated together into a single string 😵Verify that all separators are cleared in
v7.9.6.2in aDataObjFormattersapp resourcePull this PR and run the migration
Verify that all empty separators have been restored to default