Fix missing coordinate text fields for decimal coordinates#5368
Merged
Conversation
grantfitzsimmons
commented
Nov 2, 2024
CarolineDenis
approved these changes
Nov 4, 2024
Triggered by 2ca6acf on branch refs/heads/issue-5365
grantfitzsimmons
marked this pull request as ready for review
February 4, 2025 20:41
acwhite211
approved these changes
Mar 10, 2025
emenslin
approved these changes
Mar 11, 2025
emenslin
left a comment
Collaborator
There was a problem hiding this comment.
- Verify that all cases have been resolved after the migration has completed via Query Builder or SQL
- Verify that the LatLonUI plugin on Locality now displays the correct values copied from the decimal coordinate fields
Looks good!
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-10-2-release-announcement/2455/1 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR affects database migrations. See migration testing instructions.
Fixes #5365
This essentially runs the following SQL statement:
The migration is also fully reversible!
Testing instructions
Some databases are known to have this issue due to migration artifacts and this comes up from time to time.
You can usually identify databases with this issue by running the following query on them:
If any records are returned, it's a great candidate for testing this migration.
Examples that I found on the test panel are available in this document.
On
productionbefore the migrationLat1textandLong1textfields while preservingLatitude1andLongitude1values OR use one of the test databases mentioned in the earlier doc and find all records whereLatitude1exists butLat1textdoes not (using Query Builder or other methods).On
issue-5365after the migration