Add new age filter in QB by CarolineDenis · Pull Request #5272 · specify/specify7

CarolineDenis · 2024-09-12T16:56:21Z

Checklist

Self-review the PR after opening it to make sure the changes look good
and self-explanatory (or properly documented)
Add relevant issue to release milestone

Testing instructions

This PR affects database migrations. See migration testing instructions (here)

https://ciscollectionsageqbmigration52722-issue-5180.test.specifysystems.org/specify/query/new/collectionobject/

Use the ciscollections_age_qb database in the test panel. Use the 'Rocks' collection.

Go to the QB and select Collection Object, then verify the following queries. Note the the value returned in the 'Age' column is the CollectionObjectID, so no need to add an ID column in the query.

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Try setting the 'start_time' to a value that is less than the 'end_time' value. When the query runs, it should through an error "Start time must be greater than or equal to end time".
Create a Collection Object Query. Select the 'Age' field. Select the 'Any' filter. Run the query and make sure no errors occur.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is present in the query results of the 'Age' column.

start_time	end_time	strict
300	100	false
300	200	false
200	100	false
300	201	false
199	100	false
300	199	false
201	100	false
300	100	true
201	199	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
150	100	false
300	250	true
150	100	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is present in the query results of the 'Age' column.

start_time	end_time	strict
220	140	false
180	160	false
220	100	false
300	140	false
180	100	false
300	160	false
300	100	false
300	100	true
195	145	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
120	100	false
300	250	true
120	100	true
180	160	true
180	100	true
300	160	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40059 is present in the query results of the 'Age' column.

start_time	end_time	strict
200	100	false
200	10	false

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 170 and 'end_time' to 130. Run the query and verify that the Collection Object 40060 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 550 and 'end_time' to 500. Run the query and verify that the Collection Object 40061 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 200 and 'end_time' to 140. Run the query and verify that the Collection Object 40063 is returned for a query results.
Test the age query with the 'Name'. Here are a defined subset of CollectionObjectIDs that should be included in the returned query results with a given age period name:

name	co_id
Oxfordian	40063
Jurassic	40060
Jurassic	40058

Do age queries with 'Any' and explore including the follow query field paths and make sure that column in the query results have at least one row with data populated. Might be good to just set each field to 'Not Empty' one at a time, to make sure rows are returned:
- collectionobject->absoluteage
- ollectionobject->relativeage->chronostrat
- collectionobject->paleocontext->chronostrat
- collectionobject->collectionevent->paleocontext->chronostrat
- Collectionobject->collectionevent->locality->paleocontext->chronostrat

Fixes #5180

acwhite211 · 2024-09-18T22:04:23Z

Here is the QB request body to the http://localhost/stored_query/ephemeral/ api that I used to test the back-end age filtering operation:

{
  "name": "New Query",
  "contextname": "CollectionObject",
  "contexttableid": 1,
  "selectdistinct": false,
  "countonly": false,
  "formatauditrecids": false,
  "specifyuser": "/api/specify/specifyuser/1/",
  "isfavorite": true,
  "ordinal": 32767,
  "fields": [
    {
      "tablelist": "1",
      "stringid": "1.collectionobject.age",
      "fieldname": "age",
      "isrelfld": false,
      "sorttype": 0,
      "position": 2,
      "isdisplay": true,
      "operstart": 16,
      "startvalue": "10,100",
      "isnot": false
    },
    {
      "tablelist": "1",
      "stringid": "1.collectionobject.catalogNumber",
      "fieldname": "catalogNumber",
      "isrelfld": false,
      "sorttype": 0,
      "position": 0,
      "isdisplay": true,
      "operstart": 8,
      "startvalue": "",
      "isnot": false
    }
  ],
  "_tablename": "SpQuery",
  "remarks": null,
  "searchsynonymy": null,
  "smushed": null,
  "sqlstr": null,
  "timestampcreated": "2024-08-05",
  "timestampmodified": null,
  "version": 1,
  "createdbyagent": null,
  "modifiedbyagent": null,
  "offset": 0,
  "limit": 40
}

TODO: Decide what we want to return in the age column. Right now the operation does does the filtering.
TODO: Also decide on if we want to add a virtual field attribute in the datamodel, or if we will just catch specific exceptions like age in the code.

Triggered by b4a65a1 on branch refs/heads/issue-5180

… issue-5180

combs-a

Testing instructions

This PR affects database migrations. See migration testing instructions (here)

https://ciscollectionsageqbmigration52722-issue-5180.test.specifysystems.org/specify/query/new/collectionobject/

Use the ciscollections_age_qb database in the test panel. Use the 'Rocks' collection.

Go to the QB and select Collection Object, then verify the following queries. Note the the value returned in the 'Age' column is the CollectionObjectID, so no need to add an ID column in the query.

Tester comments:

So for the start and end time, it does produce an error when start is less than end--however, it seems that the same error is being thrown twice. This should be a single error.

It also incorrectly throws errors like Pashia ran into--I did some range testing, and it seems like when the end time is more than a tenth of the start time and less than 100 it gives the start value error, if that helps narrow down what's causing the issue.

agefilter1.mp4

Also, I'm wondering about returning the CO ID in that column. Oftentimes fields are added to simply filter the results, and I don't think the current behavior makes sense looking at the rest of Specify.

I'm also eh about the Name field being a picklist, since that list can get so big.

@pashiav : I also think that it should be cleared. Unless we're going to add support for having a range of names, strings cause errors.

Good work so far! This filter is pretty neat.

… issue-5180

acwhite211 · 2024-11-18T18:30:20Z

@pashiav and @emenslin thanks for catching that bug where the error is thrown for range 100 to 90, that should be fixed now. The age filter by named seems to be an issue with the tree in the database. Just try the 'Jurassic' and 'Oxfordian' names in the test.

pashiav

Testing instructions

This PR affects database migrations. See migration testing instructions (here)

https://ciscollectionsageqbmigration52722-issue-5180.test.specifysystems.org/specify/query/new/collectionobject/

Use the ciscollections_age_qb database in the test panel. Use the 'Rocks' collection.

Go to the QB and select Collection Object, then verify the following queries. Note the the value returned in the 'Age' column is the CollectionObjectID, so no need to add an ID column in the query.

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Try setting the 'start_time' to a value that is less than the 'end_time' value. When the query runs, it should through an error "Start time must be greater than or equal to end time".
Create a Collection Object Query. Select the 'Age' field. Select the 'Any' filter. Run the query and make sure no errors occur.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is present in the query results of the 'Age' column.

start_time	end_time	strict
300	100	false
300	200	false
200	100	false
300	201	false
199	100	false
300	199	false
201	100	false
300	100	true
201	199	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
150	100	false
300	250	true
150	100	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is present in the query results of the 'Age' column.

start_time	end_time	strict
220	140	false
180	160	false
220	100	false
300	140	false
180	100	false
300	160	false
300	100	false
300	100	true
195	145	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
120	100	false
300	250	true
120	100	true
180	160	true
180	100	true
300	160	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40059 is present in the query results of the 'Age' column.

start_time	end_time	strict
200	100	false
200	10	false

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 170 and 'end_time' to 130. Run the query and verify that the Collection Object 40060 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 550 and 'end_time' to 500. Run the query and verify that the Collection Object 40061 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 200 and 'end_time' to 140. Run the query and verify that the Collection Object 40063 is returned for a query results.
Test the age query with the 'Name'. Here are a defined subset of CollectionObjectIDs that should be included in the returned query results with a given age period name:

name	co_id
Oxfordian	40063
Jurassic	40060
Jurassic	40058

Do age queries with 'Any' and explore including the follow query field paths and make sure that column in the query results have at least one row with data populated. Might be good to just set each field to 'Not Empty' one at a time, to make sure rows are returned:
- collectionobject->absoluteage
- ollectionobject->relativeage->chronostrat
- collectionobject->paleocontext->chronostrat
- collectionobject->collectionevent->paleocontext->chronostrat
- Collectionobject->collectionevent->locality->paleocontext->chronostrat

Issues

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is NOT present in the query results of the 'Age' column.

Start and end times in this table still have 40058 present in the query results:

start_time	end_time	strict
180	160	true
180	100	true
300	160	true

Everything else looks good! Great job!!

Note for future testers:

From #5272 (review):

If a "Name" option is selected, then the filter is changed to "Range", the option selected for Name is the input for the start time of Range.

This will be fixed in a later pr.

grantfitzsimmons

I am still doing a full review, but I wanted to surface this concern before we proceed;

Currently, in a tree with the default Chronostratigraphy tree (no changes from the user, the one we ship in Specify 6), I get the following error:
AssertionError at /stored_query/ephemeral/ Start time must be greater than or equal to end time.

select count(*) from geologictimeperiod
where EndPeriod > StartPeriod; # 114 records returned

select count(*) from geologictimeperiod
where EndPeriod < StartPeriod; # 48 records returned

select count(*) from geologictimeperiod
where EndPeriod IS NULL or StartPeriod IS NULL; # 3 records returned

This means that 114 chronostratigraphy tree records cannot use the 'Age' function, while only 48 can be used effectively. Can we handle this error more gracefully by preventing the search in these cases? It seems excessive for the system to crash when a user constructs an otherwise valid query.

Specify 7 Crash Report - 2024-11-19T16_13_50.610Z.txt

emenslin

Testing instructions

This PR affects database migrations. See migration testing instructions (here)

https://ciscollectionsageqbmigration52722-issue-5180.test.specifysystems.org/specify/query/new/collectionobject/

Use the ciscollections_age_qb database in the test panel. Use the 'Rocks' collection.

Go to the QB and select Collection Object, then verify the following queries. Note the the value returned in the 'Age' column is the CollectionObjectID, so no need to add an ID column in the query.

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Try setting the 'start_time' to a value that is less than the 'end_time' value. When the query runs, it should through an error "Start time must be greater than or equal to end time".
Create a Collection Object Query. Select the 'Age' field. Select the 'Any' filter. Run the query and make sure no errors occur.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is present in the query results of the 'Age' column.

start_time	end_time	strict
300	100	false
300	200	false
200	100	false
300	201	false
199	100	false
300	199	false
201	100	false
300	100	true
201	199	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
150	100	false
300	250	true
150	100	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is present in the query results of the 'Age' column.

start_time	end_time	strict
220	140	false
180	160	false
220	100	false
300	140	false
180	100	false
300	160	false
300	100	false
300	100	true
195	145	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
120	100	false
300	250	true
120	100	true
180	160	true
180	100	true
300	160	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40059 is present in the query results of the 'Age' column.

start_time	end_time	strict
200	100	false
200	10	false

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 170 and 'end_time' to 130. Run the query and verify that the Collection Object 40060 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 550 and 'end_time' to 500. Run the query and verify that the Collection Object 40061 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 200 and 'end_time' to 140. Run the query and verify that the Collection Object 40063 is returned for a query results.
Test the age query with the 'Name'. Here are a defined subset of CollectionObjectIDs that should be included in the returned query results with a given age period name:

name	co_id
Oxfordian	40063
Jurassic	40060
Jurassic	40058

Do age queries with 'Any' and explore including the follow query field paths and make sure that column in the query results have at least one row with data populated. Might be good to just set each field to 'Not Empty' one at a time, to make sure rows are returned:
- collectionobject->absoluteage
- ollectionobject->relativeage->chronostrat
- collectionobject->paleocontext->chronostrat
- collectionobject->collectionevent->paleocontext->chronostrat
- Collectionobject->collectionevent->locality->paleocontext->chronostrat

Error is thrown twice when start time is less than the end time

chrome_ZvriPwGet7.mp4

Specify 7 Crash Report - 2024-11-19T15_46_25.771Z.txt

40058 is present in the query results for the last three of that table

start_time	end_time	strict
180	160	true
180	100	true
300	160	true

For the name filter, I have some concerns about how the list of names shows up, does it have to be this way or could it be a drop down like picklists are? It looks a little out of place and is hard to navigate (at least on a small screen, I'm not sure if it looks better on a bigger screen). Some other concerns are if you select an item and then click out of it, it is highlighted white and you can't read it, the background of the list is the same as the background of the query when highlighted so it blends in, and if you save a query with a name selected and reopen it the item selected shows up at the bottom instead of more centered. None of these are major, I just wanted to point them out since I could see some visual issues with these.

chrome_mpmYXOqz4U.mp4

acwhite211 · 2024-11-19T18:40:00Z

40058 is present in the query results for the last three of that table

| start_time | end_time | strict
180 160 true
180 100 true
300 160 true

This should be fixed now. Seemed to be a problem with the strict mode setting being passed to the age query logic.

pashiav

Testing instructions

This PR affects database migrations. See migration testing instructions (here)

https://ciscollectionsageqbmigration52722-issue-5180.test.specifysystems.org/specify/query/new/collectionobject/

Use the ciscollections_age_qb database in the test panel. Use the 'Rocks' collection.

Go to the QB and select Collection Object, then verify the following queries. Note the the value returned in the 'Age' column is the CollectionObjectID, so no need to add an ID column in the query.

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Try setting the 'start_time' to a value that is less than the 'end_time' value. When the query runs, it should through an error "Start time must be greater than or equal to end time".
Create a Collection Object Query. Select the 'Age' field. Select the 'Any' filter. Run the query and make sure no errors occur.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is present in the query results of the 'Age' column.

start_time	end_time	strict
300	100	false
300	200	false
200	100	false
300	201	false
199	100	false
300	199	false
201	100	false
300	100	true
201	199	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40057 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
150	100	false
300	250	true
150	100	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is present in the query results of the 'Age' column.

start_time	end_time	strict
220	140	false
180	160	false
220	100	false
300	140	false
180	100	false
300	160	false
300	100	false
300	100	true
195	145	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40058 is NOT present in the query results of the 'Age' column.

start_time	end_time	strict
300	250	false
120	100	false
300	250	true
120	100	true
180	160	true
180	100	true
300	160	true

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Use the following table to make multiple queries with differing values for the 'start_time', 'end_time', and 'strict' in the 'Range' filter. Make sure that for all these queries, that the value 40059 is present in the query results of the 'Age' column.

start_time	end_time	strict
200	100	false
200	10	false

Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 170 and 'end_time' to 130. Run the query and verify that the Collection Object 40060 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 550 and 'end_time' to 500. Run the query and verify that the Collection Object 40061 is returned for a query results.
Create a Collection Object Query. Select the 'Age' field. Select the 'Range' filter. Set the 'start_time' to 200 and 'end_time' to 140. Run the query and verify that the Collection Object 40063 is returned for a query results.
Test the age query with the 'Name'. Here are a defined subset of CollectionObjectIDs that should be included in the returned query results with a given age period name:

name	co_id
Oxfordian	40063
Jurassic	40060
Jurassic	40058

Do age queries with 'Any' and explore including the follow query field paths and make sure that column in the query results have at least one row with data populated. Might be good to just set each field to 'Not Empty' one at a time, to make sure rows are returned:
- collectionobject->absoluteage
- ollectionobject->relativeage->chronostrat
- collectionobject->paleocontext->chronostrat
- collectionobject->collectionevent->paleocontext->chronostrat
- Collectionobject->collectionevent->locality->paleocontext->chronostrat

Looks great!!

Note for future testers:
UI for the list will not be changed in this pr because it is a reused component.

UI for V2

grantfitzsimmons · 2024-11-20T18:38:43Z

So @CarolineDenis @acwhite211 this was not addressed? Are we still crashing if the user builds a seemingly OK query? Does not have to do with UI

I am still doing a full review, but I wanted to surface this concern before we proceed;

Currently, in a tree with the default Chronostratigraphy tree (no changes from the user, the one we ship in Specify 6), I get the following error:
AssertionError at /stored_query/ephemeral/ Start time must be greater than or equal to end time.
select count(*) from geologictimeperiod
where EndPeriod > StartPeriod; # 114 records returned

select count(*) from geologictimeperiod
where EndPeriod < StartPeriod; # 48 records returned

select count(*) from geologictimeperiod
where EndPeriod IS NULL or StartPeriod IS NULL; # 3 records returned
This means that 114 chronostratigraphy tree records cannot use the 'Age' function, while only 48 can be used effectively. Can we handle this error more gracefully by preventing the search in these cases? It seems excessive for the system to crash when a user constructs an otherwise valid query.

Specify 7 Crash Report - 2024-11-19T16_13_50.610Z.txt

Add new age filter in QB

d4841a8

Fixes #5180

CarolineDenis added this to the 7.9.9 milestone Sep 12, 2024

initial qb age filter operations back-end

6c6f174

CarolineDenis commented Sep 19, 2024

View reviewed changes

Comment thread specifyweb/frontend/js_src/lib/components/QueryBuilder/FieldFilter.tsx

CarolineDenis and others added 16 commits September 25, 2024 10:01

Add age type to fieldType

9c73f3d

Add age to any filter

281d989

Test geo picklist

e8580e6

Define geologic system picklist for age virtual field

d528339

Remove import

b07a368

Remove imports

61e4283

Fix tests

74b472a

Add strict button

559a7aa

Handle new strict filter

563077e

Allow only one strict filter per row

da768ff

Remove comment

58fa1f3

Remove code

95f4ea6

Remove import

906ed85

Add Strict nonStrict icon

5804d29

Merge branch 'production' into issue-5180-1

24d0d6a

Merge branch 'issue-5178-1' into issue-5180-1

233f446

sharadsw suggested changes Oct 1, 2024

View reviewed changes

CarolineDenis and others added 5 commits October 1, 2024 11:24

Chnage geo picklist to CO picklist

dc01dea

Reorder icons

46017f9

adapt age filter query to new request format

c541dfb

Merge branch 'issue-5180-1' into issue-5180

b4a65a1

Lint code with ESLint and Prettier

c98b464

Triggered by b4a65a1 on branch refs/heads/issue-5180

CarolineDenis changed the base branch from production to issue-5178-1 October 1, 2024 22:09

CarolineDenis added 2 commits October 2, 2024 07:14

Add new type for age

68f74b3

Define age as string in front end

123ce1f

acwhite211 and others added 2 commits November 18, 2024 10:47

Merge branch 'issue-5180' of https://github.com/specify/specify7 into…

d793c2f

… issue-5180

Add comment

a90d756

combs-a previously requested changes Nov 18, 2024

View reviewed changes

acwhite211 added 2 commits November 18, 2024 11:33

cast float for state and end time

bf7f228

Merge branch 'issue-5180' of https://github.com/specify/specify7 into…

d02cab9

… issue-5180

CarolineDenis requested review from combs-a, grantfitzsimmons and pashiav November 18, 2024 18:39

pashiav suggested changes Nov 18, 2024

View reviewed changes

CarolineDenis requested a review from emenslin November 19, 2024 14:17

grantfitzsimmons previously requested changes Nov 19, 2024

View reviewed changes

emenslin previously requested changes Nov 19, 2024

View reviewed changes

fix passing of strict value to query

095dd0e

CarolineDenis requested review from emenslin and pashiav November 19, 2024 18:41

pashiav approved these changes Nov 20, 2024

View reviewed changes

pashiav requested a review from a team November 20, 2024 15:07

CarolineDenis added 2 commits November 20, 2024 08:18

Merge remote-tracking branch 'origin/production' into issue-5180

b0d8c44

Update migration

4348b88

CarolineDenis merged commit e9d3f1c into production Nov 20, 2024

CarolineDenis deleted the issue-5180 branch November 20, 2024 16:56

acwhite211 mentioned this pull request Nov 22, 2024

Add valid chronostrat filter to geo_time relativeage and paleocontext queries #5411

Merged

6 tasks

melton-jason mentioned this pull request Jan 7, 2025

Can't make report from query saved in production #6022

Closed

acwhite211 mentioned this pull request Feb 25, 2025

Extended Age Query not performing search as expected, strict mode is not being followed #6271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new age filter in QB - #5272

Add new age filter in QB#5272
CarolineDenis merged 57 commits into
productionfrom
issue-5180

CarolineDenis commented Sep 12, 2024 •

edited by acwhite211

Loading

Uh oh!

acwhite211 commented Sep 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

combs-a left a comment

Uh oh!

acwhite211 commented Nov 18, 2024

Uh oh!

pashiav left a comment

Uh oh!

grantfitzsimmons left a comment •

edited

Loading

Uh oh!

emenslin left a comment

Uh oh!

acwhite211 commented Nov 19, 2024

Uh oh!

pashiav left a comment

Uh oh!

grantfitzsimmons commented Nov 20, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

CarolineDenis commented Sep 12, 2024 • edited by acwhite211 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Testing instructions

Uh oh!

acwhite211 commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

combs-a left a comment

Choose a reason for hiding this comment

Testing instructions

Tester comments:

Uh oh!

acwhite211 commented Nov 18, 2024

Uh oh!

pashiav left a comment

Choose a reason for hiding this comment

Testing instructions

Issues

Uh oh!

grantfitzsimmons left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emenslin left a comment

Choose a reason for hiding this comment

Testing instructions

Uh oh!

acwhite211 commented Nov 19, 2024

Uh oh!

pashiav left a comment

Choose a reason for hiding this comment

Testing instructions

Uh oh!

grantfitzsimmons commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CarolineDenis commented Sep 12, 2024 •

edited by acwhite211

Loading

acwhite211 commented Sep 18, 2024 •

edited

Loading

grantfitzsimmons left a comment •

edited

Loading

grantfitzsimmons commented Nov 20, 2024 •

edited

Loading