Skip to content

Filter Taxon QCBX by CollectionObjectType tree - #5248

Merged
sharadsw merged 7 commits into
productionfrom
issue-5213
Oct 1, 2024
Merged

Filter Taxon QCBX by CollectionObjectType tree#5248
sharadsw merged 7 commits into
productionfrom
issue-5213

Conversation

@sharadsw

@sharadsw sharadsw commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Fixes #5213
Fixes #4982

The cotype -> treedef value can be retrieved from the Determination resource used by the Taxon QCBX, which will be used to filter Taxon values

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Use a db with multiple trees in the same collection
  • Go to Data Entry > Collection Object
  • Enter a CollectionObjectType
  • Add a determination
  • Verify Taxon field of the determination gets filtered by the selected COType's tree definition

@maxpatiiuk maxpatiiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread specifyweb/frontend/js_src/lib/components/QueryComboBox/index.tsx
@sharadsw sharadsw added this to the 7.9.8 milestone Sep 3, 2024
@sharadsw
sharadsw marked this pull request as ready for review September 3, 2024 14:47
@sharadsw
sharadsw requested a review from a team September 3, 2024 14:47

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Use a db with multiple trees in the same collection
  • Go to Data Entry > Collection Object
  • Enter a CollectionObjectType
  • Add a determination
  • Verify Taxon field of the determination gets filtered by the selected COType's tree definition

@emenslin
emenslin requested a review from a team September 5, 2024 19:33
@sharadsw

sharadsw commented Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

TODO: Remove determination save blocker that was added as a workaround previously

@pashiav pashiav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Use a db with multiple trees in the same collection
  • Go to Data Entry > Collection Object
  • Enter a CollectionObjectType
  • Add a determination
  • Verify Taxon field of the determination gets filtered by the selected COType's tree definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Determination taxon query combo box should be filtering by COT tree Add business logic for MOTs

5 participants