Fix Table Aggregation Separator being set to undefined if it matches default "; "#5240
Merged
Conversation
alesan99
marked this pull request as ready for review
August 26, 2024 14:14
pashiav
approved these changes
Aug 26, 2024
pashiav
left a comment
Contributor
There was a problem hiding this comment.
- Verify the separator is still there and isn't blank.
Working as expected. Good job!
edge
Screen.Recording.2024-08-26.at.1.33.59.PM.mov
pr
Screen.Recording.2024-08-26.at.1.58.08.PM.mov
Areyes42
approved these changes
Aug 26, 2024
Areyes42
left a comment
Contributor
There was a problem hiding this comment.
Testing instructions
- Go to App Resources -> Record Formatters -> and open any Table Aggregation
- Set the separator to "; "
- Save
- Verify the separator is still there and isn't blank.
Separator gets retained now, nice job!
grantfitzsimmons
approved these changes
Aug 26, 2024
emenslin
approved these changes
Aug 27, 2024
emenslin
left a comment
Collaborator
There was a problem hiding this comment.
Testing instructions
- Go to App Resources -> Record Formatters -> and open any Table Aggregation
- Set the separator to "; "
- Save
- Verify the separator is still there and isn't blank.
Looks good, separator doesn't get deleted
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5154
Table Aggregation Separators should no longer be getting set to undefined during serialization if they match the default ("; ").
All previously affected databases will need to have their separators restored separately. Though it is safe to assume all blanks were originally "; ".
Checklist
and self-explanatory (or properly documented)
Testing instructions