Skip to content

Display system tables by default in query list menu option - #5133

Merged
CarolineDenis merged 8 commits into
productionfrom
issue-5128
Jul 26, 2024
Merged

Display system tables by default in query list menu option#5133
CarolineDenis merged 8 commits into
productionfrom
issue-5128

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Fixes #5128

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

@maxpatiiuk maxpatiiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this, should we simply make audit log tables not be system tables? that is something that is easily changeable on the back-end
there are many system tables that rightfully should remain hidden (at very least to reduce noise and confusion). there are also many sp6-only tables that we don't want to see in Sp7

@CarolineDenis

Copy link
Copy Markdown
Contributor Author

NOTES:

Should be in the query list:

  • Collection
  • Discipline
  • Division
  • SpAuditLog

@CarolineDenis
CarolineDenis requested review from a team, acwhite211 and sharadsw July 24, 2024 15:28
@CarolineDenis CarolineDenis modified the milestones: 7.9.8, 7.9.7 Jul 24, 2024
@CarolineDenis
CarolineDenis marked this pull request as ready for review July 24, 2024 15:29
@CarolineDenis
CarolineDenis removed request for a team, acwhite211 and sharadsw July 24, 2024 15:48

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

Looks good, the 4 tables above now show in the query builder
Screenshot 2024-07-24 105220

@combs-a combs-a left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

Looks good, everything is showing and you can query just fine

image

image

@Areyes42 Areyes42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

Looks good, and they still query correctly!

@CarolineDenis
CarolineDenis requested a review from sharadsw July 24, 2024 16:24

@maxpatiiuk maxpatiiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if this fixes the immediate bug, let's not quickly jump to creating a new list of tables - every such list we create is one more place where things can go out of date or bugs can slip in. it would be better if we can adjust the existing system to fit the new requirement, rather than add a new system as an extra layer on top...

Comment thread specifyweb/specify/datamodel.py
Comment thread specifyweb/frontend/js_src/lib/components/SchemaConfig/Tables.tsx Outdated
Comment thread specifyweb/frontend/js_src/lib/components/SchemaConfig/Tables.tsx Outdated
@CarolineDenis
CarolineDenis merged commit dff3564 into production Jul 26, 2024
@CarolineDenis
CarolineDenis deleted the issue-5128 branch July 26, 2024 13:38
@specifysoftware

Copy link
Copy Markdown

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Sp Audit Log no longer shows up in query builder

9 participants