Skip to content

Remove gallery icon from fictious record set#4220

Merged
CarolineDenis merged 2 commits into
xml-editorfrom
issue-4211
Dec 13, 2023
Merged

Remove gallery icon from fictious record set#4220
CarolineDenis merged 2 commits into
xml-editorfrom
issue-4211

Conversation

@CarolineDenis

Copy link
Copy Markdown
Contributor

Fixes #4211

@maxpatiiuk maxpatiiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this solution if @grantfitzsimmons is ok

Comment thread specifyweb/frontend/js_src/lib/components/FormSliders/RecordSelectorFromIds.tsx Outdated
@CarolineDenis
CarolineDenis marked this pull request as ready for review November 20, 2023 14:12
@CarolineDenis
CarolineDenis requested review from a team and maxpatiiuk November 20, 2023 14:12
@pashiav

pashiav commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Instructions for testers? @CarolineDenis

@CarolineDenis

Copy link
Copy Markdown
Contributor Author

@pashiav

  • go to Data Entry
  • verify that the gallery icon is not present in the header
  • save the form and add a new one
  • save the second one
  • verify the record set icon is now present but not the gallery icon
  • click on record set icon to create a record set
  • verify that now the gallery icon is present
  • open any record set and verify gallery icon is present
  • NOTES: gallery icon is disabled if there is no attachments

@bronwyncombs bronwyncombs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gallery icon is not shown on data entry form headers or fictitious record set headers.
Screenshot 2023-11-22 at 10 51 36 AM
Screenshot 2023-11-22 at 10 52 39 AM

In a record set, gallery icon is now shown:
Screenshot 2023-11-22 at 10 53 28 AM

You get this dialog if no attachments are added upon clicking the icon:
Screenshot 2023-11-22 at 10 53 57 AM

I know that disabling the icon in this case was discussed. I don't have a preference one way or the other really but am requesting review from @grantfitzsimmons to follow up

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galley icon does not show up unless it is an actual record set. Even if there are no attachments the gallery icon is there, as Bronwyn said, I don't care if it is there or not, but it depends on what Grant thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

xml-editor: Attachment gallery button should not display unless there are attachments

5 participants