Add additional instructions for django migrations - #3628
Merged
Conversation
maxpatiiuk
requested changes
Jun 17, 2023
maxpatiiuk
left a comment
Member
There was a problem hiding this comment.
- Small clarification: It's not that root is required, but that user with more permissions is required (my master user has all permissions, so I had no issues with this - of course that is not suitable for production). Worth clarifying or not worth the complexity?
- When you modify docker compose, I believe you have to rebuild for changes to env variables to take effect - not sure. Could you try changing the MASTER_NAME and see if changes apply after restarting without rebuild?
Member
Author
I understood this before writing, but I was worried it would add too much complexity to explain this.
I can try this at a later date. I need to catch up on 3 weeks of messages 😉 |
maxpatiiuk
self-requested a review
June 21, 2023 04:33
maxpatiiuk
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3626
Is this explanation satisfactory?