Skip to content

Add prepType to query table to edit them in same fictitious record set - #3441

Merged
CarolineDenis merged 8 commits into
productionfrom
issue-2754
Jun 5, 2023
Merged

Add prepType to query table to edit them in same fictitious record set#3441
CarolineDenis merged 8 commits into
productionfrom
issue-2754

Conversation

@CarolineDenis

Copy link
Copy Markdown
Contributor

Fixes #2754

@CarolineDenis
CarolineDenis requested review from a team and maxpatiiuk May 3, 2023 14:40

@grantfitzsimmons grantfitzsimmons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The Preparation Type table is sorted at the bottom rather than where it should be alphabetically. Not sure why this is.

    image image
  2. How is this any different from default behavior? This is still not satisfactory & does not really make it any easier to create new prep types

    image

    This kind of thing really needs its own UI (as it has in 6) where the user doesn't feel like it's detached from the schema configuration process. It should appear like this:

    image image

    Where you can add new prep types from the dialog & this should be accessible automatically when editing the preparation type picklist in the schema configuration tool.

@CarolineDenis

Copy link
Copy Markdown
Contributor Author

Screenshot 2023-05-17 at 11 56 29 AM
What about displaying a PreType form with a slider that allows to navigate between preType and + / - buttons in the edit pick list dialog when Entire Table is selected?

@CarolineDenis

CarolineDenis commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

@maxpatiiuk
When you have time, could you please look into the following issues:

  • [ There is a TypeScript error attached to'resource' line 197 in FormCells/index.tsx ]
  • [ in the subview, when 'entire table' is selected, the add button currently opens a query dialog. Instead, it should display a new empty form, replacing the last opened resource. Additionally, the number in the slider should increase . ]
  • [when selecting 'institution' in the table name, a error dialog appears ]
  • [when selecting 'project' in table name, nothing is displayed ]

@maxpatiiuk

Copy link
Copy Markdown
Member

There is a TypeScript error attached to 'resource' line 197 in FormCells/index.tsx

Fixed. See c1b084a

when selecting 'institution' in the table name, a error dialog appears

We didn't use domain filter correctly. See the fix in 19666c9

in the subview, when 'entire table' is selected, the add button currently opens a query dialog. Instead, it should display a new empty form, replacing the last opened resource. Additionally, the number in the slider should increase

This one is quite tricky. Fortunately, it's either already fixed by #3125, or needs to be fixed on that branch anyway. Basically, we need to allow for use case of creating independent records from inside of a subview, rather than just linking to existing independent records. Thus, it would be simplest to just make this PR wait till that PR is fixed

when selecting 'project' in table name, nothing is displayed

You were correct - it's simply because there are no projects in the kufish database

@maxpatiiuk
maxpatiiuk marked this pull request as draft May 22, 2023 18:25
@CarolineDenis

Copy link
Copy Markdown
Contributor Author

If the feature in readOnly is satisfying we can merge this PR.
The add/edit feature will be implemented with #3125

@grantfitzsimmons grantfitzsimmons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarolineDenis looks good!

I am sad only because we cannot add new prep type records from the form, but I know it is due to the issues with independent subviews.

@grantfitzsimmons grantfitzsimmons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarolineDenis looks good!

I am sad only because we cannot add new prep type records from the form, but I know it is due to the issues with independent subviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Introduce visual "PrepType" editor

3 participants