Bad Tree Structure Renames Taxonomic Rank

[carlosmbe]

Describe the bug
If you change the Parent of Taxon of a new Taxon to something that doesn't make sense in the context of Taxonomic Rank the Taxonomic Rank turns into something like this /api/specify/taxontreedefitem/2/

Screen Recording

Shorter.Smaller.Recording.mp4

To Reproduce
Steps to reproduce the behavior:

1. Go to a taxonomy tree
2. Click on Add Child
3. Make Parent of Child, Life and Taxonomic Rank, Kingdom
4. Change Parent of Child to something to that makes no sense. Like a child of Kingdom
5. See error

Expected behavior
Taxonomic Rank becomes empty or just something else that a non technical person can get

Desktop:

• OS: Mac OSx Ventura
• Browser: Chrome
• Specify 7 Version: 7.8.12 and 7.8.11

Database Name: Any

[melton-jason]

Duplicate of #2637.

@grantfitzsimmons
This is probably something that should be handled by business rules.
The solution would be to set the rank of any tree node to null if its parent changed and the old rank was invalid.

I can push a fix for this in v7.8.12-prerelease if needed, but I will need to fix this on xml-editor as well, separately.
Can we reevaluate how likely this issue is to happen in a production database? If still very unlikely, it may be safe to wait for xml-editor to be released.

[melton-jason]

Nevermind, I was wrong! Specify specially renders the Taxonomic Rank pick list and has special logic in the function that renders it.
I will fix this on the v7.8.12-prerelease branch 🥳

[realVinayak]

@melton-jason I think this is known issue with Taxonomic Rank showing as the url.

Also,

The solution would be to set the rank of any tree node to null if its parent changed and the old rank was invalid.

Do you mean setting the rank to null in just the formUI or in the database? I hope the former lol.

[melton-jason]

@melton-jason I think this is known issue with Taxonomic Rank showing as the url.

Also,

The solution would be to set the rank of any tree node to null if its parent changed and the old rank was invalid.

Do you mean setting the rank to null in just the formUI or in the database? I hope the former lol.

Just clearing the rank id in the form if the old rank was invalid.
It was discussed as a proposed solution in #2637 (comment)

[realVinayak]

Ah okay, I wanted to clarify that this wasn't done in the database but just in the form. However, I agree with Theresa @tlammer solution in that case. We shouldn't assume what rank user wanted.

[carlosmbe]

Quick update. Issue is present in Geography Tree as well. But not Litho Strart, Chrono Strart or Storage

[grantfitzsimmons]

https://morpaleo2may-v79-dev.test.specifysystems.org/specify/tree/lithostrat/?conformation=%7E%7E1%7E3%7E5%7E12-%7E11%7E13------

This is happening in v7.9-dev in the Litho Strat tree

[grantfitzsimmons]

Duplicate of #2637 unless @melton-jason says otherwise