small changes to tag-value lexer/parser #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Armin Tänzer <[email protected]>
meretp
reviewed
Mar 28, 2023
| "ORGANIZATION_VALUE", | ||
| "PERSON_VALUE", | ||
| "DATE", | ||
| "ISO8601_DATE", |
Collaborator
There was a problem hiding this comment.
As there was recently a discussion about the date not being exatly ISO8601 I am wondering if we should really name it like that.
Member
There was a problem hiding this comment.
Let's be clear: it is an ISO-8601 formatted date.
It doesn't allow all variants of ISO-8601, which include 20230328T122341.123 or 20230328T12XXXX or 2023-33. You would find very few implementations handling all these variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
DATEtoISO8601_DATE, don't inherit fromobject