Skip to content

[TASK] Mark nullable parameters explicit #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kszymukowicz merged 1 commit into from
May 14, 2025
Merged

[TASK] Mark nullable parameters explicit #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Classes/Dispatcher/AbstractDispatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function __construct(
public function processOperationByRequest(
RequestContext $requestContext,
Request $request,
ResponseInterface &$response = null
?ResponseInterface &$response = null
): string {
foreach ($this->apiResourceRepository->getAll() as $apiResource) {
try {
Expand Down Expand Up @@ -90,7 +90,7 @@ protected function processOperation(
OperationInterface $operation,
array $route,
Request $request,
ResponseInterface &$response = null
?ResponseInterface &$response = null
): string {
$handlers = $this->getHandlersSupportingOperation($operation, $request);

Expand Down
2 changes: 1 addition & 1 deletion Classes/Exception/AbstractException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ abstract class AbstractException extends \Exception implements ExceptionInterfac
*/
protected string $title;

protected static function translate(string $key, array $arguments = null): ?string
protected static function translate(string $key, ?array $arguments = null): ?string
{
return LocalizationUtility::translate($key, 't3api', $arguments);
}
Expand Down
2 changes: 1 addition & 1 deletion Classes/Service/RouteService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static function getFullApiBaseUrl(): string
. '/' . ltrim(self::getFullApiBasePath(), '/');
}

public static function routeHasT3ApiResourceEnhancerQueryParam(ServerRequestInterface $request = null): bool
public static function routeHasT3ApiResourceEnhancerQueryParam(?ServerRequestInterface $request = null): bool
{
$request = $request ?? self::getRequest();
return $request instanceof ServerRequest && is_array($request->getQueryParams())
Expand Down
Loading