[action] [PR:23898] Remove stale xfail for cacl/test_cacl_application.py#23976
Merged
mssonicbld merged 1 commit intosonic-net:202511from Apr 16, 2026
Merged
[action] [PR:23898] Remove stale xfail for cacl/test_cacl_application.py#23976mssonicbld merged 1 commit intosonic-net:202511from
mssonicbld merged 1 commit intosonic-net:202511from
Conversation
### Description of PR Summary: Remove the stale xfail mark for `cacl/test_cacl_application.py` from `tests_mark_conditions.yaml`. The xfail was added to wait for [sonic-net/sonic-host-services#301](sonic-net/sonic-host-services#301) to be included in sonic-buildimage. That PR was merged on 2025-10-24 (~6 months ago) and has been included in builds for months. The xfail is no longer needed. Fixes sonic-net#21175 ### Type of change - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? Issue [sonic-net#21175](sonic-net#21175) was created to track removing the xfail for `cacl/test_cacl_application.py` after [sonic-net/sonic-host-services#301](sonic-net/sonic-host-services#301) was merged into sonic-buildimage. The PR was merged on 2025-10-24 and the xfail condition is now satisfied. Keeping the stale xfail suppresses real failures and pollutes nightly test reports. #### How did you do it? Removed the 4-line xfail block from `tests/common/plugins/conditional_mark/tests_mark_conditions.yaml`: `yaml xfail: reason: "Wait PR sonic-net/sonic-host-services#301 include in sonic-buildimage" conditions: - "sonic-net#21175" ` The skip condition for VS (`asic_type in ['vs']`) is kept as-is since it serves a different purpose (PR testing). #### How did you verify/test it? - Verified [sonic-net/sonic-host-services#301](sonic-net/sonic-host-services#301) was merged on 2025-10-24 - Checked Kusto test results: `cacl.test_cacl_application` tests are running on HW testbeds with reasonable pass rates - Confirmed no CRLF corruption in the diff (exactly 4 lines removed) #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case? N/A ### Documentation N/A Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
12 tasks
Collaborator
Author
|
Original PR: #23898 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Remove the stale xfail mark for
cacl/test_cacl_application.pyfromtests_mark_conditions.yaml.The xfail was added to wait for sonic-net/sonic-host-services#301 to be included in sonic-buildimage. That PR was merged on 2025-10-24 (~6 months ago) and has been included in builds for months. The xfail is no longer needed.
Fixes #21175
Type of change
Back port request
Approach
What is the motivation for this PR?
Issue #21175 was created to track removing the xfail for
cacl/test_cacl_application.pyafter sonic-net/sonic-host-services#301 was merged into sonic-buildimage.The PR was merged on 2025-10-24 and the xfail condition is now satisfied. Keeping the stale xfail suppresses real failures and pollutes nightly test reports.
How did you do it?
Removed the 4-line xfail block from
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml:`yaml
xfail:
reason: "Wait PR sonic-net/sonic-host-services#301 include in sonic-buildimage"
conditions:
`
The skip condition for VS (
asic_type in ['vs']) is kept as-is since it serves a different purpose (PR testing).How did you verify/test it?
cacl.test_cacl_applicationtests are running on HW testbeds with reasonable pass ratesAny platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A