[BUG] Fix is_multi_vrf_peer KeyError for vsonic neighbors#23966
Open
kalash-nexthop wants to merge 1 commit intosonic-net:masterfrom
Open
[BUG] Fix is_multi_vrf_peer KeyError for vsonic neighbors#23966kalash-nexthop wants to merge 1 commit intosonic-net:masterfrom
kalash-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Kalash Nainwal <kalash@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1089850: ✅Stage Test:
|
yxieca
approved these changes
Apr 17, 2026
Collaborator
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix KeyError: 'is_multi_vrf_peer' in test_bgp_router_id when peers are vsonic VMs. And while at it, fix the same issue in test_bgp_gr_helper too. This key is set only for cEOS peers, and so the tests fail when peers are vSONIC VMs.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The nbrhosts fixture only sets
is_multi_vrf_peerfor EOS neighbors, not sonic. Whentest_bgp_router_id.pyruns with vsonic peers,nbrhost["is_multi_vrf_peer"]raises aKeyError.How did you do it?
Use
.get("is_multi_vrf_peer", False)which is the same pattern already used in tests/bgp/conftest.py (e.g.,node.get('is_multi_vrf_peer', False)).How did you verify/test it?
Run tests/bgp/test_bgp_router_id.py on a testbed with vsonic neighbors
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation