Experiment with different source/observer tracking mechanism#2576
Merged
ryansolid merged 2 commits intosolidjs:betafrom Jan 26, 2026
Merged
Experiment with different source/observer tracking mechanism#2576ryansolid merged 2 commits intosolidjs:betafrom
ryansolid merged 2 commits intosolidjs:betafrom
Conversation
🦋 Changeset detectedLatest commit: a49638c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 21104319443Details
💛 - Coveralls |
| if (!TransitionRunning) node.value = value; | ||
| } else node.value = value; | ||
| if (node.observers && node.observers.length) { | ||
| if (node.observers && node.observers) { |
There was a problem hiding this comment.
if (node.observers && node.observers) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use fused linked lists to make v1 signals faster.
Before:
After
How did you test this change?
pnpm run test(I'm not sure if our test coverage of Suspense will catch everything here though)