Open
Conversation
796fb62 to
c859bcd
Compare
c859bcd to
feef63f
Compare
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
f17c89b to
b2c8255
Compare
b2c8255 to
7a170cc
Compare
cheempz
approved these changes
Mar 13, 2026
Contributor
cheempz
left a comment
There was a problem hiding this comment.
LGTM but very much "looking" not "reviewing" ;) There were CodeQL findings https://github.com/solarwinds/apm-java/runs/66999829386?pr=433 but nothing that jumped out at me.
One question, would this require any change to the diagnostic tool command?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.