Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Bump block-buffer from 0.9.0 to 0.10.4#31606

Merged
illia-bobyr merged 1 commit intosolana-labs:masterfrom
illia-bobyr:pr/bump-block-buffer-0.10.4
May 18, 2023
Merged

Bump block-buffer from 0.9.0 to 0.10.4#31606
illia-bobyr merged 1 commit intosolana-labs:masterfrom
illia-bobyr:pr/bump-block-buffer-0.10.4

Conversation

@illia-bobyr
Copy link
Copy Markdown
Contributor

Problem

Dependabot was unable to upgrade block-buffer.

buffer-buffer removed the "block-padding" feature in this PR: RustCrypto/utils#671

Summary of Changes

Remove the "block-padding" feature dependency and upgrade block-buffer to 0.10.4.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2023

Codecov Report

Merging #31606 (8415069) into master (d40212c) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #31606     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         737      737             
  Lines      205972   205972             
=========================================
- Hits       168739   168702     -37     
- Misses      37233    37270     +37     

@CriesofCarrots
Copy link
Copy Markdown
Contributor

Mark as ready for review?

@illia-bobyr
Copy link
Copy Markdown
Contributor Author

Mark as ready for review?

I was hoping to land that dependency reduction PR first. It would allow me to remove the solana_program_count constraint increase.

Thank you for the reminder.

I still hope the dependency reduction PR will land on Monday, and then I'll rebase this one and ask for your approval on this one.

PS. I thought I replied yesterday %)

`buffer-buffer` removed the "block-padding" feature in this PR:

  RustCrypto/utils#671
@illia-bobyr illia-bobyr marked this pull request as ready for review May 16, 2023 22:44
@illia-bobyr
Copy link
Copy Markdown
Contributor Author

It is now passing without increasing the limit on the solana_program crate recompilations.

@illia-bobyr illia-bobyr merged commit a57fe0c into solana-labs:master May 18, 2023
@illia-bobyr illia-bobyr deleted the pr/bump-block-buffer-0.10.4 branch May 18, 2023 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants