MPT-11914 Initial setup of wps and ruff rules#477
Merged
Conversation
svazquezco
reviewed
Jul 28, 2025
d1d097e to
b6d243d
Compare
b6d243d to
8063a44
Compare
d3rky
commented
Aug 4, 2025
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| class Command(AdobeBaseCommand): |
Collaborator
Author
Member
There was a problem hiding this comment.
This command covers the requirement from Sync Improvements. It syncs only 3yc_enroll status if it is in one of the temporary states and does full sync when it changes to commited. process_3yc does some other stuff as well which I do not fully understand, but it is definitely something more than just a synchronization. I think it make sense to keep pure sync separately from other operations.
| ) | ||
|
|
||
|
|
||
| def resubmit_3yc_commitment_request(mpt_client, is_recommitment=False): |
Collaborator
Author
Member
There was a problem hiding this comment.
I am not sure, but it wasn't used yet when I joined
ruben-sebrango
approved these changes
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
jentyk
approved these changes
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
8063a44 to
ca85fc9
Compare
|
svazquezco
reviewed
Aug 5, 2025
Comment on lines
+21
to
+23
| """ | ||
|
|
||
| Create Reseller Account on Adobe. |
Contributor
There was a problem hiding this comment.
Suggested change
| """ | |
| Create Reseller Account on Adobe. | |
| """Create Reseller Account on Adobe. |
svazquezco
reviewed
Aug 5, 2025
| response.raise_for_status() | ||
| return response.json() | ||
|
|
||
| def _do_not_make_return_params(self): |
Contributor
There was a problem hiding this comment.
It's strange that mypy doesn't report anything about the typing. Do we have the correct config?
Suggested change
| def _do_not_make_return_params(self): | |
| def _do_not_make_return_params(self) -> dict[str, str]: |
Contributor
There was a problem hiding this comment.
Ah! I've just realized we don't have mypy in this repo. 😢
svazquezco
reviewed
Aug 5, 2025
Comment on lines
+13
to
15
| line_items (list): List of item to search. | ||
| sku (str): The partial SKU to search in | ||
| the list of item. |
Contributor
There was a problem hiding this comment.
Suggested change
| line_items (list): List of item to search. | |
| sku (str): The partial SKU to search in | |
| the list of item. | |
| line_items: List of item to search. | |
| sku: The partial SKU to search in the list of item. |
svazquezco
reviewed
Aug 5, 2025
|
|
||
|
|
||
| def get_item_by_partial_sku(items, sku): | ||
| def get_item_by_partial_sku(line_items, sku): |
Contributor
There was a problem hiding this comment.
Suggested change
| def get_item_by_partial_sku(line_items, sku): | |
| def get_item_by_partial_sku(line_items: list, sku: str) -> str: |
svazquezco
reviewed
Aug 5, 2025
Comment on lines
+29
to
32
| Converts Marketplace Line id to integer by extracting sequencial part of the line id. | ||
|
|
||
| Example: ALI-1234-1234-1234-0001 --> 1 | ||
| """ |
Contributor
There was a problem hiding this comment.
I missed the Args and return sections
svazquezco
reviewed
Aug 5, 2025
Comment on lines
+328
to
329
| def get_transfers_to_check(product_id: str): | ||
| """ |
Contributor
There was a problem hiding this comment.
Looks like we also forgot the return typing in the methods below. They're not required now but...just in case
Suggested change
| def get_transfers_to_check(product_id: str): | |
| """ | |
| def get_transfers_to_check(product_id: str) -> list: | |
| """ |
svazquezco
reviewed
Aug 5, 2025
| from django.core.management.base import BaseCommand | ||
|
|
||
|
|
||
| class AdobeBaseCommand(BaseCommand): |
svazquezco
reviewed
Aug 5, 2025
Comment on lines
+172
to
190
| # Plugin configs: | ||
| flake8-import-conventions.banned-from = [ "ast", "datetime" ] | ||
| flake8-import-conventions.aliases = { datetime = "dt" } | ||
| flake8-quotes.inline-quotes = "double" | ||
| mccabe.max-complexity = 6 | ||
| pydocstyle.convention = "google" | ||
|
|
||
| [tool.ruff.lint.per-file-ignores] | ||
| "tests/*.py" = [ | ||
| "D103", # missing docstring in public function | ||
| "S101", # asserts | ||
| "S105", # hardcoded passwords | ||
| "S404", # subprocess calls are for tests | ||
| "S603", # do not require `shell=True` | ||
| "S607", # partial executable paths | ||
| ] | ||
|
|
||
| [tool.ruff.lint.isort] | ||
| known-third-party = ["swo"] |
Contributor
There was a problem hiding this comment.
I'd like to use the new ruff format
Suggested change
| # Plugin configs: | |
| flake8-import-conventions.banned-from = [ "ast", "datetime" ] | |
| flake8-import-conventions.aliases = { datetime = "dt" } | |
| flake8-quotes.inline-quotes = "double" | |
| mccabe.max-complexity = 6 | |
| pydocstyle.convention = "google" | |
| [tool.ruff.lint.per-file-ignores] | |
| "tests/*.py" = [ | |
| "D103", # missing docstring in public function | |
| "S101", # asserts | |
| "S105", # hardcoded passwords | |
| "S404", # subprocess calls are for tests | |
| "S603", # do not require `shell=True` | |
| "S607", # partial executable paths | |
| ] | |
| [tool.ruff.lint.isort] | |
| known-third-party = ["swo"] | |
| [tool.ruff.lint.flake8-import-conventions] | |
| aliases = { datetime = "dt" } | |
| banned-from = [ "ast", "datetime" ] | |
| [tool.ruff.lint.flake8-quotes] | |
| inline-quotes = "double" | |
| [tool.ruff.lint.isort] | |
| known-third-party = ["swo"] | |
| [tool.ruff.lint.mccabe] | |
| max-complexity = 6 | |
| [tool.ruff.lint.per-file-ignores] | |
| "tests/*.py" = [ | |
| "D103", # missing docstring in public function | |
| "S101", # asserts | |
| "S105", # hardcoded passwords | |
| "S404", # subprocess calls are for tests | |
| "S603", # do not require `shell=True` | |
| "S607", # partial executable paths | |
| ] | |
| [tool.ruff.lint.pydocstyle] | |
| convention = "google" |
svazquezco
approved these changes
Aug 5, 2025
Contributor
svazquezco
left a comment
There was a problem hiding this comment.
Great refactor! ❤️ That was a lot of work! I'm sure this will help us reach the next level 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.