Skip to content

MPT-19654 Sellers now supports multiple currencies#252

Merged
d3rky merged 1 commit intomainfrom
bugfix/MPT-19654/fix-sellers-endpoint
Mar 27, 2026
Merged

MPT-19654 Sellers now supports multiple currencies#252
d3rky merged 1 commit intomainfrom
bugfix/MPT-19654/fix-sellers-endpoint

Conversation

@d3rky
Copy link
Copy Markdown
Contributor

@d3rky d3rky commented Mar 27, 2026

Closes MPT-19654

  • Updated the seller factory fixture to use currencies (plural) instead of currency (singular) when constructing the seller payload, enabling support for multiple currencies in the sellers endpoint

@d3rky d3rky requested a review from a team as a code owner March 27, 2026 10:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 748bdbd6-4d35-4b41-ac00-11206051e915

📥 Commits

Reviewing files that changed from the base of the PR and between eeca121 and 4d3ea72.

📒 Files selected for processing (1)
  • tests/e2e/accounts/sellers/conftest.py

📝 Walkthrough

Walkthrough

A test fixture's seller factory payload was updated to use the currencies key instead of currency when constructing the returned seller dictionary. The function parameter and its default behavior remain unchanged.

Changes

Cohort / File(s) Summary
Test fixture payload update
tests/e2e/accounts/sellers/conftest.py
Changed seller factory return payload key from currency to currencies in dictionary construction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the correct format MPT-19654.
Test Coverage Required ✅ Passed Pull request only modifies test fixture file in tests/ folder with no code files modified outside tests/.
Single Commit Required ✅ Passed The PR contains exactly one commit (4d3ea72 MPT-19654 Sellers now supports multiple currencies) as verified by git rev-list --count HEAD ^main returning 1, with clean linear history.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@d3rky d3rky merged commit fab87cd into main Mar 27, 2026
4 checks passed
@d3rky d3rky deleted the bugfix/MPT-19654/fix-sellers-endpoint branch March 27, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants