MPT-19478 fix e2e queue tests and add fixtures for disabled queues

[jentyk]

Closes MPT-19478

Changes

• Added internal: False to the queue_data fixture payload
• Created new pytest fixtures for disabled queues: created_disabled_queue (sync) and async_created_disabled_queue (async)
• Enabled e2e queue tests by removing @pytest.mark.skip decorators from test functions
• Enhanced test assertions to verify queue state transitions (checking status == "Active" and status == "Disabled")
• Updated test_activate_queue to use the new created_disabled_queue fixture
• Improved test_create_queue assertion to verify Queue instance type instead of generic non-None checks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jentyk]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 66e8134a-9a05-472f-98ce-3d932ca39caa

📥 Commits

Reviewing files that changed from the base of the PR and between e20527f and 7e299bc.

📒 Files selected for processing (3)

• tests/e2e/helpdesk/queues/conftest.py
• tests/e2e/helpdesk/queues/test_async_queues.py
• tests/e2e/helpdesk/queues/test_sync_queues.py

---

📝 Walkthrough

Walkthrough

Pull request re-enables previously skipped end-to-end tests for synchronous and asynchronous helpdesk queue operations. Introduces new fixtures for disabled queue states and updates assertions to verify specific Queue instances and operation statuses instead of generic non-None checks.

Changes

Cohort / File(s)	Summary
Test Fixtures tests/e2e/helpdesk/queues/conftest.py	Added internal: False to queue_data fixture payload. Introduced created_disabled_queue and async_created_disabled_queue fixtures that invoke helpdesk.queues.disable(...) on already-created queues and assert status equals "Disabled".
Queue Operation Tests tests/e2e/helpdesk/queues/test_async_queues.py, tests/e2e/helpdesk/queues/test_sync_queues.py	Removed @pytest.mark.skip decorators from seven queue tests to enable their execution. Updated assertions to verify Queue instance types and operation statuses ("Active", "Disabled") instead of non-None checks. Modified test_activate_queue to use created_disabled_queue fixture for testing state transitions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• MPT-18370 Add helpdesk queues API services with unit and e2e test coverage #243: The fixture changes and queue test modifications directly build upon the helpdesk queue service behavior and test scaffolding introduced in this PR, extending functionality with disabled queue state testing.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Jira Issue Key In Title	✅ Passed	The PR title contains exactly one Jira issue key in the format MPT-XXXX (MPT-19478) at the beginning.
Test Coverage Required	✅ Passed	PR only modifies test files within tests/ folder; no production code outside tests/ was changed.
Single Commit Required	✅ Passed	The pull request contains exactly one commit (7e299bc) as confirmed by multiple independent git commands and file history analysis.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}