Skip to content

MPT-18372 Add helpdesk parameter groups API services with unit and e2e test coverage#246

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-18372
Mar 24, 2026
Merged

MPT-18372 Add helpdesk parameter groups API services with unit and e2e test coverage#246
jentyk merged 1 commit intomainfrom
feat/MPT-18372

Conversation

@jentyk
Copy link
Member

@jentyk jentyk commented Mar 24, 2026

Summary

  • Add sync/async Helpdesk Parameter Groups services for /public/v1/helpdesk/parameter-groups
  • Add sync/async nested Parameter Group Parameters services for /public/v1/helpdesk/parameter-groups/{group_id}/parameters
  • Expose new helpdesk.parameter_groups entrypoint on sync and async Helpdesk clients
  • Add unit tests for service wiring, endpoint paths, mixin methods, and nested .parameters(group_id) factory
  • Add e2e test suites for parameter groups and nested group parameters (sync/async), marked flaky and skipped

Testing

  • make check-all

Closes MPT-18372

Release Notes

  • Added synchronous and asynchronous Helpdesk Parameter Groups services for endpoint /public/v1/helpdesk/parameter-groups with full CRUD operations and pagination support
  • Added synchronous and asynchronous nested Parameter Group Parameters services for endpoint /public/v1/helpdesk/parameter-groups/{group_id}/parameters with factory method access via .parameters(group_id)
  • Exposed new helpdesk.parameter_groups entrypoint on both sync and async Helpdesk client classes
  • Added comprehensive unit tests covering service instantiation, endpoint path validation, mixin method availability, and nested factory method behavior
  • Added end-to-end test suites for parameter groups and nested group parameters (both sync and async variants), marked as flaky and skipped pending issue MPT-18373 resolution

@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: eec54226-4fff-4b4b-94f7-55014cee5ea8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)

Comment @coderabbitai help to get the list of available commands and usage tips.

@jentyk jentyk changed the title Add helpdesk parameter groups API services with unit and e2e test coverage MPT-18372 Add helpdesk parameter groups API services with unit and e2e test coverage Mar 24, 2026
@sonarqubecloud
Copy link

@jentyk jentyk marked this pull request as ready for review March 24, 2026 14:00
@jentyk jentyk requested a review from a team as a code owner March 24, 2026 14:00
@jentyk jentyk merged commit 609839f into main Mar 24, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-18372 branch March 24, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants