Skip to content

Fix LegacyPressable #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 3 commits into from
Mar 6, 2026
Merged

Fix LegacyPressable #4016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2135fa0
Use old button in LegacyPressable
m-bert Mar 5, 2026
3c444ec
Web button
m-bert Mar 5, 2026
16c73de
Extarct type
m-bert Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common-app/src/new_api/components/buttons/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function ButtonWrapper({
<ButtonComponent
style={[styles.button, { backgroundColor: color }]}
onPress={() =>
feedback?.current?.showMessage(`[${ButtonComponent.name}] onLongPress`)
feedback?.current?.showMessage(`[${ButtonComponent.name}] onPress`)
}
onLongPress={() => {
feedback?.current?.showMessage(`[${ButtonComponent.name}] onLongPress`);
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-gesture-handler/src/components/GestureHandlerButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export interface ButtonProps extends ViewProps, AccessibilityProps {
/**
* Invoked on mount and layout changes.
*/
onLayout?: (event: LayoutChangeEvent) => void;
onLayout?: ((event: LayoutChangeEvent) => void) | undefined;

@m-bert m-bert Mar 5, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary because of #4012


/**
* Used for testing-library compatibility, not passed to the native component.
Expand Down Expand Up @@ -101,7 +101,7 @@ export interface ButtonProps extends ViewProps, AccessibilityProps {
testOnly_onLongPress?: Function | null | undefined;
}

const ButtonComponent =
export const ButtonComponent =
RNGestureHandlerButtonNativeComponent as HostComponent<ButtonProps>;

export default function GestureHandlerButton({ style, ...rest }: ButtonProps) {
Expand Down
12 changes: 9 additions & 3 deletions packages/react-native-gesture-handler/src/components/GestureHandlerButton.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import * as React from 'react';
import { View } from 'react-native';
import { View, ViewProps } from 'react-native';

export default React.forwardRef<React.ComponentRef<typeof View>>(
(props, ref) => <View ref={ref} accessibilityRole="button" {...props} />
type ButtonProps = ViewProps & {
ref?: React.Ref<React.ComponentRef<typeof View>>;
};

export const ButtonComponent = (props: ButtonProps) => (
<View accessibilityRole="button" {...props} />
);

Comment thread
m-bert marked this conversation as resolved.
export default ButtonComponent;
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/components/Pressable/Pressable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
StyleProp,
ViewStyle,
} from 'react-native';
import NativeButton from '../GestureHandlerButton';
import { ButtonComponent as NativeButton } from '../GestureHandlerButton';

@akwasniewski akwasniewski Mar 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark, you don't have to change it if you don't think it's necessary: I think it would be sensible to simply change the name of the ButtonComponent to NativeButton. Also after changes in the ../GestureHandlerButton, the Button imported in the v3 version is the wrapped one, thus aliasing it as PureNativeButton seems weird, we can just remove the alias.

@m-bert m-bert Mar 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave it as it is for now and leave those renames for other PRs. This one already grew bigger than I expected 😅

import {
gestureToPressableEvent,
addInsets,
Expand Down
Loading