You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For now, NativeDetector doesn't throw error when it is used outside of GestureHandlerRootView. This PR moves check from LegacyDetector to GestureDetector.
Will we be exporting LegacyGestureDetector as a standalone component? If so, the check should stay in both.
Well, if exporting everything as GestureDetector works fine I don't think we have to export it as a standalone component. WDYT @akwasniewski?
The idea of putting all detectors in the new GestureDetector was not to export them seperately. We only want to export this multi-use component, I think it's less effort for the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For now,
NativeDetectordoesn't throw error when it is used outside ofGestureHandlerRootView. This PR moves check fromLegacyDetectortoGestureDetector.Test plan
Tested on the following example: