fixed reanimated handlers#3757
Closed
akwasniewski wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Already fixed in #3758 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After recent changes
hasWorkletEventHandlersfunction was broken, it alwasy returned false, asHandlerCallbacksis a set so we have to check with.hasnotisoperator.Without this
LogicDetectorwill throw weird errors asgesture.config.shouldUseReanimatedDetectoris always false._Note: I still have to check whether this change did not break anything else
Test plan
Check whether
NativeDetectorwith a reanimatedLogicDetectorunderneath loads on iOS.