chore: Remove unused env variable#3091
Merged
Merged
Conversation
j-piasecki
approved these changes
Sep 16, 2024
m-bert
added a commit
that referenced
this pull request
Oct 13, 2025
> [!NOTE] > Supersede #3335 # Description This PR contains cherry picked commits from #3335 as merging changes after migrating into monorepo became quite painful 😞 1. `appProject` seems to be left unused after #3091 2. adding `configureEach` allows for [lazy task initialization](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview) # Original description ## Description This PR optimises pre-build time of Gesture Handler android, taking it down from ~7s to ~0.6s, a 11x improvement. - baseline: - time 6.776s ([link](https://gradle.com/s/h5iselfgzhafi)) - time 7.391s ([link](https://scans.gradle.com/s/6sz4ssuepvema)) - optimised: - time 0.687s ([link](https://gradle.com/s/zwiujfjblp64s)) - time 0.560s ([link](https://gradle.com/s/i5xqega7pazja)) - time 0.596s ([link](https://gradle.com/s/ohcnspquhmau4)) fixes: #2865 Optimisation of the `example` app pre-build time will be done in a separate PR, so far i took it down from 13s to 0.1s (caching & on-demand building). ## Test plan - Run `./gradlew help --scan` to see pre-build performance - Build app to see everything still works
j-piasecki
pushed a commit
that referenced
this pull request
Oct 27, 2025
> [!NOTE] > Supersede #3335 This PR contains cherry picked commits from #3335 as merging changes after migrating into monorepo became quite painful 😞 1. `appProject` seems to be left unused after #3091 2. adding `configureEach` allows for [lazy task initialization](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview) This PR optimises pre-build time of Gesture Handler android, taking it down from ~7s to ~0.6s, a 11x improvement. - baseline: - time 6.776s ([link](https://gradle.com/s/h5iselfgzhafi)) - time 7.391s ([link](https://scans.gradle.com/s/6sz4ssuepvema)) - optimised: - time 0.687s ([link](https://gradle.com/s/zwiujfjblp64s)) - time 0.560s ([link](https://gradle.com/s/i5xqega7pazja)) - time 0.596s ([link](https://gradle.com/s/ohcnspquhmau4)) fixes: #2865 Optimisation of the `example` app pre-build time will be done in a separate PR, so far i took it down from 13s to 0.1s (caching & on-demand building). - Run `./gradlew help --scan` to see pre-build performance - Build app to see everything still works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to be unused