Fix remove interests#188
Merged
Merged
Conversation
tarcieri
reviewed
May 2, 2018
|
|
||
| ev_io_start(selector->ev_loop, &monitor->ev_io); | ||
| if (monitor->interests) | ||
| ev_io_start(selector->ev_loop, &monitor->ev_io); |
Contributor
There was a problem hiding this comment.
Personally I prefer braces around if statements
Member
Author
There was a problem hiding this comment.
Yes, excellent suggestion, I will update.
Contributor
|
One nit, otherwise LGTM |
tarcieri
approved these changes
May 2, 2018
Member
Author
|
Thanks :) |
- Don't add the IO to the event loop unless it has interests. - Don't remove the IO from the event loop if it doesn't have interests. - Assert that there were interests when adding the monitor to the ready list.
0c27b7b to
92f9f3b
Compare
Member
Author
|
Okay, fixed the bracket. You are clear for merging. |
Contributor
|
Released as 2.3.1 |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 6, 2018
## 2.3.1 (2018-05-03) * [#188](socketry/nio4r#188) Fix remove interests ([@ioquatix])
msk
pushed a commit
to msk/pkgsrc
that referenced
this pull request
May 11, 2026
## 2.3.1 (2018-05-03) * [#188](socketry/nio4r#188) Fix remove interests ([@ioquatix])
jperkin
pushed a commit
to TritonDataCenter/pkgsrc
that referenced
this pull request
May 14, 2026
## 2.3.1 (2018-05-03) * [#188](socketry/nio4r#188) Fix remove interests ([@ioquatix])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tarcieri can you please review, merge and release? Thanks.