forked from fsprojects/Rezoom.SQL
-
Notifications
You must be signed in to change notification settings - Fork 0
experiment addition of schema support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smoothdeveloper
wants to merge
6
commits into
paket-and-new-dotnetsdk-for-main-solution
Choose a base branch
from
initial-schema-support
base: paket-and-new-dotnetsdk-for-main-solution
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d8f59d
experiment addition of schema support
smoothdeveloper 94ebc3a
create schema test, a failing one to start with...
smoothdeveloper b0820d0
more interesting test failure
smoothdeveloper ce78320
fixing create schema statement handling
smoothdeveloper 8b7d390
* fix test (not null is invalid in column definition)
smoothdeveloper 9f1ef28
handle schema drop
smoothdeveloper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,11 @@ open System.Collections.Generic | |
| open Rezoom.SQL.Compiler.InferredTypes | ||
|
|
||
| type private ModelChange(model : Model, inference : ITypeInferenceContext) = | ||
| member private this.CreateSchema(create: InfCreateSchemaStmt) = | ||
| stateful { | ||
| let schema = { SchemaName = create.SchemaName; Objects = Map.empty } | ||
| return! ComplexModelOps.createSchema schema create | ||
| } |> State.runForOutputState model |> Some | ||
| member private this.CreateTable(create : InfCreateTableStmt) = | ||
| stateful { | ||
| let! tableName = ComplexModelOps.qualifyTemp create.Temporary create.Name | ||
|
|
@@ -64,6 +69,8 @@ type private ModelChange(model : Model, inference : ITypeInferenceContext) = | |
| return! ModelOps.dropView objName | ||
| | DropTable -> | ||
| return! ModelOps.dropTable objName | ||
| | DropSchema -> | ||
| return! ModelOps.dropSchema { Value = Some drop.ObjectName.ObjectName; Source = objName.Source } | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rspeele: Note that it is |
||
| } |> State.runForOutputState model |> Some | ||
| member this.CreateIndex(create : InfCreateIndexStmt) = | ||
| stateful { | ||
|
|
@@ -75,6 +82,7 @@ type private ModelChange(model : Model, inference : ITypeInferenceContext) = | |
| member this.Stmt(stmt : InfStmt) = | ||
| match stmt with | ||
| | AlterTableStmt alter -> this.AlterTable(alter) | ||
| | CreateSchemaStmt create -> this.CreateSchema(create) | ||
| | CreateTableStmt create -> this.CreateTable(create) | ||
| | CreateViewStmt create -> this.CreateView(create) | ||
| | CreateIndexStmt create -> this.CreateIndex(create) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rspeele: This is simplest thing that seems to work.
I'm prepending any object resolution here, which may have an impact (no test failing though), should I only do that when the
name.SchemaNameis empty? or should it be handled another way?