Fix API key generation with retry logic and validation#15
Open
smith wants to merge 1 commit into
Open
Conversation
The script could fail silently and write an api_key.yml with an empty key. Now stores the curl response in a variable, validates it contains an encoded key before writing, and retries up to 30 times to handle ES not being fully ready for security API calls. Closes #7 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/create-api-key.shto store curl response in a variable and validate before writing the output fileapi_key:value)Closes #7
Test plan
docker compose down -v && docker compose up— verifysetup_api_keylogs show retry attempts and eventual successdocker compose logs setup_api_keyfor "API key successfully created" message🤖 Generated with Claude Code