Fix AssertionError when AUTO cases are requested outside a "test_" module #320
Merged
Conversation
The correct file-name pattern is "cases_", not "case_"
Contributor
Author
|
PR is good to go from my side. @smarie, feel free to add any suggestions |
smarie
reviewed
Nov 20, 2023
smarie
reviewed
Nov 20, 2023
Owner
|
Thanks @michele-riva ! I made a few minor comments |
Co-authored-by: Sylvain Marié <sylvain.marie@schneider-electric.com>
Co-authored-by: Sylvain Marié <sylvain.marie@schneider-electric.com>
Contributor
Author
|
Thanks for the suggestions, @smarie. I have just implemented them. |
smarie
reviewed
Nov 21, 2023
Owner
|
All good, thanks @michele-riva ! |
|
This broke a use case where we defined our "tests" in It would be nice if this used the pytest config to determine where to look for AUTO cases |
Owner
|
I was not aware of this possibility @mroeschke ! And since I have been designing pytest-cases just for this (creating benchmarks) I really agree with fixing this. Let's move this to an explicit issue and discuss possible workarounds |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309