Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jul 22, 2025

Summary

This PR adds the workflows.featured.{add|list|remove|set} methods:

Testing

Gather shortcut trigger IDs and a user token for the following methods:

app.client.workflows_featured_add(channel_id="C0123456789", trigger_ids=["Ft0123456789"])
app.client.workflows_featured_list(channel_ids="C0123456789")
app.client.workflows_featured_remove(channel_id="C0123456789", trigger_ids=["Ft0123456789"])
app.client.workflows_featured_set(channel_id="C0123456789", trigger_ids=["Ft0123456789"])

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimeg zimeg added this to the 3.37.0 milestone Jul 22, 2025
@zimeg zimeg requested review from WilliamBergamin and vegeris July 22, 2025 18:52
@zimeg zimeg self-assigned this Jul 22, 2025
@zimeg zimeg added enhancement M-T: A feature request for new functionality semver:minor web-client Version: 3x labels Jul 22, 2025
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (8ffd0c4) to head (f16ea4e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
+ Coverage   84.83%   84.91%   +0.08%     
==========================================
  Files         113      113              
  Lines       12823    12892      +69     
==========================================
+ Hits        10878    10947      +69     
  Misses       1945     1945              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me 💯 thanks for working on this 🚀

Is there an easy way to create an integration tests in integration_tests/web for these new endpoints? Its always nice to have them in order to validate that things work as expected

@zimeg
Copy link
Member Author

zimeg commented Aug 1, 2025

Is there an easy way to create an integration tests in integration_tests/web for these new endpoints?

@WilliamBergamin Thanks so much for calling this out 👁️‍🗨️ ✨

We might need a workflow shortcut trigger ID which I'm not sure we have quick access to in the current testing setups. Do let me know if there's someplace you think we can find this! I'll hold off on merging this for now with hopes that we find this ID soon 👾

@WilliamBergamin
Copy link
Contributor

WilliamBergamin commented Aug 1, 2025

Needing a valid workflow shortcut trigger ID seems too complex for the integration tests 🤔

Ship it as is 🚢 the changes look good to me 💯

@zimeg
Copy link
Member Author

zimeg commented Aug 1, 2025

@WilliamBergamin Ahh thanks for confirming what I feared too... And the review! Onwards with the merge we go! 🚢

@zimeg zimeg merged commit 8922dc8 into main Aug 1, 2025
12 checks passed
@zimeg zimeg deleted the zimeg-feat-web-api-workflows-featured branch August 1, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality semver:minor Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants