-
Notifications
You must be signed in to change notification settings - Fork 848
feat(web): add workflows.featured.{add|list|remove|set} methods #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
+ Coverage 84.83% 84.91% +0.08%
==========================================
Files 113 113
Lines 12823 12892 +69
==========================================
+ Hits 10878 10947 +69
Misses 1945 1945 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me 💯 thanks for working on this 🚀
Is there an easy way to create an integration tests in integration_tests/web for these new endpoints? Its always nice to have them in order to validate that things work as expected
@WilliamBergamin Thanks so much for calling this out 👁️🗨️ ✨ We might need a workflow shortcut trigger ID which I'm not sure we have quick access to in the current testing setups. Do let me know if there's someplace you think we can find this! I'll hold off on merging this for now with hopes that we find this ID soon 👾 |
|
Needing a valid workflow shortcut trigger ID seems too complex for the integration tests 🤔 Ship it as is 🚢 the changes look good to me 💯 |
|
@WilliamBergamin Ahh thanks for confirming what I feared too... And the review! Onwards with the merge we go! 🚢 |
Summary
This PR adds the
workflows.featured.{add|list|remove|set}methods:Testing
Gather shortcut trigger IDs and a user token for the following methods:
Category
tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.