feat(web-api): add authorship arguments to assistant threads and chat stream#2455
feat(web-api): add authorship arguments to assistant threads and chat stream#2455
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 62 62
Lines 10251 10251
Branches 415 415
=======================================
Hits 8961 8961
Misses 1269 1269
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
🏷️ note: Marking this as |
# Conflicts: # packages/web-api/src/types/request/chat.ts
🦋 Changeset detectedLatest commit: b8f5c2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zimeg
left a comment
There was a problem hiding this comment.
📣 A few links to reference for kind reviewers!
| /** | ||
| * @description Emoji to use as the icon for this message. Overrides `icon_url`. | ||
| * @example :chart_with_upwards_trend: | ||
| */ | ||
| icon_emoji?: string; | ||
| /** | ||
| * @description Image URL to use as the icon for this message. | ||
| * @example http://lorempixel.com/48/48 | ||
| */ | ||
| icon_url?: string; | ||
| /** | ||
| * @description The bot's username to display. | ||
| * @example My Bot | ||
| */ | ||
| username?: string; |
There was a problem hiding this comment.
| /** | ||
| * @description Emoji to use as the icon for this message. Overrides `icon_url`. | ||
| * @example :chart_with_upwards_trend: | ||
| */ | ||
| icon_emoji?: string; | ||
| /** | ||
| * @description Image URL to use as the icon for this message. | ||
| * @example http://lorempixel.com/48/48 | ||
| */ | ||
| icon_url?: string; | ||
| /** | ||
| * @description The bot's username to display. | ||
| * @example My Bot | ||
| */ | ||
| username?: string; |
There was a problem hiding this comment.
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looks good to me @zimeg! Thanks for putting this PR together.
📝 I've added a small suggestion. I'm holding off on the approval since auto-merge is enabled. Once we decide whether to take or leave the suggestion, then I can toss a ✅ here!
| icon_emoji?: string; | ||
| /** | ||
| * @description Image URL to use as the icon for this message. | ||
| * @example http://lorempixel.com/48/48 |
There was a problem hiding this comment.
nit: This URL seems to be down, but that's not a big deal.
Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
srtaalej
left a comment
There was a problem hiding this comment.
looks great and is working well for me ⭐ ⭐ ⭐
Summary
This PR adds the "authorship" arguments -
icon_emoji,icon_url, andusername- to the following methods:Reviewers
Please feel free to experiment with the following code example:
Requirements