health: publish test results to code cov #1282
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1282 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 222 222
Lines 7501 7501
=======================================
Hits 6823 6823
Misses 678 678 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
LGTM! Thanks so much for giving test results this attention 🙏 ✨
And the insights shown already are so interesting! With excitement of future improvements to testings all around, I think this is good to merge when the time is right 🚢
| pytest tests/adapter_tests/ \ | ||
| --ignore=tests/adapter_tests/socket_mode/ \ | ||
| --ignore=tests/adapter_tests/asgi/ \ | ||
| --junitxml=reports/test_adapter.xml |
There was a problem hiding this comment.
👏 I'm a big fan of this change!
I noticed this now covers the google_cloud_functions adapter which I'm not sure was run in CI beforehand 👾
.github/workflows/tests.yml
Outdated
| uses: codecov/test-results-action@v1 | ||
| with: | ||
| directory: ./reports/ | ||
| files: test*.xml |
There was a problem hiding this comment.
| files: test*.xml | |
| files: ./**/test*.xml |
https://github.com/slackapi/bolt-python/actions/runs/14134899037/job/39604145700#step:14:183
Right now this raises a warning in outputs 🔍
Some files were not found --- {"not_found_files": ["test*.xml"]}
I think a standalone directory option might be another option, and this isn't a blocker at all! Just wanting to share findings ✨
There was a problem hiding this comment.
Thats a great catch 🥇 I totally missed that warning, I'll try testing a few things out
Summary
This PR is inspired by slackapi/node-slack-sdk#2178
It updates the CI pipeline to publish the test results to codcov and provide some neat reporting details
Testing
Check out the results on codcov
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.