Skip to content

health: increase CI coverage #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 5 commits into from
Mar 20, 2025
Merged

health: increase CI coverage #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e507e14
health: increase CI coverage
WilliamBergamin Mar 18, 2025
7071bcd
Bump ubuntu down for 3.6, 3.7 compatibility
WilliamBergamin Mar 18, 2025
c5358a9
We are stuck on ubuntu 20 if we want to support 3.6
WilliamBergamin Mar 18, 2025
12b6bc9
Ignore config warning for pytest-asyncio when it is not installed
WilliamBergamin Mar 20, 2025
a7035f0
Merge branch 'main' into improve-ci-coverage
WilliamBergamin Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ jobs:
- name: Run tests for HTTP Mode adapters (Tornado)
run: |
pytest tests/adapter_tests/tornado/
- name: Run tests for HTTP Mode adapters (WSGI)
run: |
pytest tests/adapter_tests/wsgi/
Comment on lines +71 to +73
Copy link
Member

@zimeg zimeg Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to match the other test setups, but I'm wondering if this warning is expected or not?

../../../../../opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/_pytest/config/__init__.py:1441
  /opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/_pytest/config/__init__.py:1441: PytestConfigWarning: Unknown config option: asyncio_mode
  
    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

🔗 https://github.com/slackapi/bolt-python/actions/runs/13931970838/job/38991049073#step:16:23

Copy link
Contributor Author

@WilliamBergamin WilliamBergamin Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💯 we can ignore this warning since it comes from trying to configure pytest-asyncio when it is not installed

- name: Install async dependencies
run: |
pip install -r requirements/async.txt
Expand All @@ -82,3 +85,10 @@ jobs:
run: |
# Requires async test dependencies
pytest tests/adapter_tests/asgi/
- name: Install all dependencies
run: |
pip install -r requirements/testing.txt
Comment on lines +88 to +90
Copy link
Member

@zimeg zimeg Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Should this be with the "Install all dependencies" job?

It's not super clear to me which steps use which dependencies and TBH I wouldn't be against separating sync from async tests if dependencies are shared in unexpected ways 👾

Copy link
Contributor Author

@WilliamBergamin WilliamBergamin Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss I see what you mean it might be better to do thins in a separate PR 🤔

- name: Run asynchronous tests
run: |
pytest tests/slack_bolt_async/
pytest tests/scenario_tests_async/
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ log_date_format = "%Y-%m-%d %H:%M:%S"
filterwarnings = [
"ignore:\"@coroutine\" decorator is deprecated since Python 3.8, use \"async def\" instead:DeprecationWarning",
"ignore:The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.:DeprecationWarning",
"ignore:Unknown config option. asyncio_mode:pytest.PytestConfigWarning", # ignore warning when asyncio_mode is set but pytest-asyncio is not installed
]
asyncio_mode = "auto"

Expand Down
Loading