Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

This PR aims to add official support for python 3.13

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added enhancement New feature or request area:async area:sync github_actions Pull requests that update GitHub Actions code labels Dec 13, 2024
@WilliamBergamin WilliamBergamin added this to the 1.21.4 milestone Dec 13, 2024
@WilliamBergamin WilliamBergamin self-assigned this Dec 13, 2024
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (ed32039) to head (0c76947).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removing Falcon 2.x testing should be fine in Dec 2024

@WilliamBergamin WilliamBergamin merged commit 5f4c847 into slackapi:main Dec 16, 2024
14 checks passed
@WilliamBergamin WilliamBergamin deleted the python_3_13_support branch December 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async area:sync enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants