Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2024

Updates the requirements on falcon to permit the latest version.

Release notes

Sourced from falcon's releases.

4.0.1

Falcon 4.0.1 is a minor point release addressing a Python distribution issue in Falcon 4.0.0.

Fixed

Installing Falcon 4.0.0 unexpectedly copies many unintended directories from the source tree to the venv’s site-packages. This issue has been rectified, and our CI has been extended with new tests (that verify what is actually installed from the distribution) to make sure this regression does not resurface. (#2384)

Changelog

Sourced from falcon's changelog.

Changelog for Falcon 4.0.1

Summary

This is a minor point release to take care of a couple of bugs that we did not catch for 4.0.0.

.. towncrier release notes start

Contributors to this Release

Many thanks to those who contributed to this bugfix release:


Otherwise, ensure the summary has been brought up to date; be sure to highlight
key changes in this release.

Next, update the contributors and render towncrier fragments by running:

$ tox -e changelog_release
</code></pre>
<p>Note that if the previous release was made on a branch, the tool may get
confused, and try to scan too many commits, which will unfortunately get
rate-limited (and fail) unless you provide a GitHub auth token.</p>
<p>The workaround is to make sure you have already aggregated the list of
contributors in the prior commits leading to the release, and only run the
towncrier tool:</p>
<pre lang="sh"><code>$ tools/towncrier_draft.py
</code></pre>
<p>Examine the updated RST as well as the rendered HTML docs and make any
adjustments as needed. On OS X it's as simple as:</p>
<pre lang="sh"><code>$ open docs/_build/html/changes/index.html
</code></pre>
<p>Or on Linux:</p>
<pre lang="sh"><code>&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>

<ul>
<li><a href="https://github.com/falconry/falcon/commit/1ef41db2ea17eb0015962c3f22668796de27dcd1&quot;&gt;&lt;code&gt;1ef41db&lt;/code&gt;&lt;/a> chore: prepare 4.0.1</li>
<li><a href="https://github.com/falconry/falcon/commit/a44f137e24ae0344e289aa02072b7628f1d2153e&quot;&gt;&lt;code&gt;a44f137&lt;/code&gt;&lt;/a> fix(dist): only detect <code>falcon*</code> as packages (<a href="https://redirect.github.com/falconry/falcon/issues/2385&quot;&gt;#2385&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/d872d92cde0c5fb1ffb75080cbfc41f2219552b1&quot;&gt;&lt;code&gt;d872d92&lt;/code&gt;&lt;/a> chore: open 4.0.1 bugfix branch</li>
<li><a href="https://github.com/falconry/falcon/commit/53512207659097c348980f7ed16a9632be0b6127&quot;&gt;&lt;code&gt;5351220&lt;/code&gt;&lt;/a> docs(changes): prepare 4.0.0 stable (<a href="https://redirect.github.com/falconry/falcon/issues/2378&quot;&gt;#2378&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/61c1047db2ef02556da9c28cc42c813b52db3aa9&quot;&gt;&lt;code&gt;61c1047&lt;/code&gt;&lt;/a> docs(changes): prepare Falcon <code>4.0.0rc1</code> (<a href="https://redirect.github.com/falconry/falcon/issues/2374&quot;&gt;#2374&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/9debc9e29a033d13c628c6cd81a4d31c2e87f793&quot;&gt;&lt;code&gt;9debc9e&lt;/code&gt;&lt;/a> chore: prepare <code>4.0.0b4</code> (<a href="https://redirect.github.com/falconry/falcon/issues/2369&quot;&gt;#2369&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/872a45e50ec07b6ca3f24688ff059126a88fbbaf&quot;&gt;&lt;code&gt;872a45e&lt;/code&gt;&lt;/a> docs(http_date_to_dt): describe the scope of timezone-aware date changes (<a href="https://redirect.github.com/falconry/falcon/issues/2368&quot;&gt;#2368&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/2556dbe9e07d21162f0d565ea1928dcf1a4bf158&quot;&gt;&lt;code&gt;2556dbe&lt;/code&gt;&lt;/a> chore: prepare <code>4.0.0b3</code> (<a href="https://redirect.github.com/falconry/falcon/issues/2367&quot;&gt;#2367&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/db33c9c3dd5a45a2ec8a10ec3e19dc416ffd1e02&quot;&gt;&lt;code&gt;db33c9c&lt;/code&gt;&lt;/a> fix(multipart): do not require CRLF after the closing delimiter (<a href="https://redirect.github.com/falconry/falcon/issues/2366&quot;&gt;#2366&lt;/a&gt;)&lt;/li>
<li><a href="https://github.com/falconry/falcon/commit/06fdf2885d70149803dbc47324ae8c951b7e58b3&quot;&gt;&lt;code&gt;06fdf28&lt;/code&gt;&lt;/a> chore: prepare <code>4.0.0b2</code> (<a href="https://redirect.github.com/falconry/falcon/issues/2362&quot;&gt;#2362&lt;/a&gt;)&lt;/li>
<li>Additional commits viewable in <a href="https://github.com/falconry/falcon/compare/3.1.1...4.0.1&quot;&gt;compare view</a></li>
</ul>
</details>

<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 1, 2024
@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (12b4498) to head (a1e6feb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         222      222           
  Lines        7505     7505           
=======================================
  Hits         6825     6825           
  Misses        680      680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/pip/falcon-gte-3.1.1-and-lt-5 branch from bd08a4c to bb5cacc Compare November 1, 2024 22:52
Updates the requirements on [falcon](https://github.com/falconry/falcon) to permit the latest version.
- [Release notes](https://github.com/falconry/falcon/releases)
- [Changelog](https://github.com/falconry/falcon/blob/master/RELEASE.md)
- [Commits](falconry/falcon@3.1.1...4.0.1)

---
updated-dependencies:
- dependency-name: falcon
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/falcon-gte-3.1.1-and-lt-5 branch from bb5cacc to a1e6feb Compare November 1, 2024 22:58
@seratch
Copy link
Contributor

seratch commented Nov 1, 2024

https://github.com/slackapi/bolt-python/actions/runs/11637501337/job/32410795427?pr=1197

slack_bolt/adapter/falcon/resource.py:4: error: Unused "type: ignore" comment  [unused-ignore]
slack_bolt/adapter/falcon/resource.py:38: error: Incompatible types in assignment (expression has type "str", variable has type "Never")  [assignment]
slack_bolt/adapter/falcon/resource.py:54: error: Incompatible types in assignment (expression has type "str", variable has type "Never")  [assignment]
slack_bolt/adapter/falcon/async_resource.py:4: error: Unused "type: ignore" comment  [unused-ignore]
slack_bolt/adapter/falcon/async_resource.py:5: error: Unused "type: ignore" comment  [unused-ignore]
slack_bolt/adapter/falcon/async_resource.py:44: error: Incompatible types in assignment (expression has type "str", variable has type "Never")  [assignment]

It seems Falcon 5 has different type hints than Falcon 3 & 4. We will resolve these mypy errors before merging this version range change.

@seratch seratch self-assigned this Nov 1, 2024
@seratch seratch added this to the 1.x milestone Nov 1, 2024
@seratch seratch mentioned this pull request Nov 5, 2024
8 tasks
@seratch seratch closed this in #1199 Nov 5, 2024
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/falcon-gte-3.1.1-and-lt-5 branch November 5, 2024 01:46
@seratch seratch modified the milestones: 1.x, 1.21.3 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants