Skip to content

Add title argument to SetSuggestedPrompts arguments #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Oct 28, 2024
Merged

Add title argument to SetSuggestedPrompts arguments #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions slack_bolt/context/set_suggested_prompts/async_set_suggested_prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import List, Dict, Union
from typing import List, Dict, Union, Optional

from slack_sdk.web.async_client import AsyncWebClient
from slack_sdk.web.async_slack_response import AsyncSlackResponse
Expand All @@ -19,7 +19,11 @@ def __init__(
self.channel_id = channel_id
self.thread_ts = thread_ts

async def __call__(self, prompts: List[Union[str, Dict[str, str]]]) -> AsyncSlackResponse:
async def __call__(
self,
prompts: List[Union[str, Dict[str, str]]],
title: Optional[str] = None,
) -> AsyncSlackResponse:
prompts_arg: List[Dict[str, str]] = []
for prompt in prompts:
if isinstance(prompt, str):
Expand All @@ -31,4 +35,5 @@ async def __call__(self, prompts: List[Union[str, Dict[str, str]]]) -> AsyncSlac
channel_id=self.channel_id,
thread_ts=self.thread_ts,
prompts=prompts_arg,
title=title,
)
9 changes: 7 additions & 2 deletions slack_bolt/context/set_suggested_prompts/set_suggested_prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import List, Dict, Union
from typing import List, Dict, Union, Optional

from slack_sdk import WebClient
from slack_sdk.web import SlackResponse
Expand All @@ -19,7 +19,11 @@ def __init__(
self.channel_id = channel_id
self.thread_ts = thread_ts

def __call__(self, prompts: List[Union[str, Dict[str, str]]]) -> SlackResponse:
def __call__(
self,
prompts: List[Union[str, Dict[str, str]]],
title: Optional[str] = None,
) -> SlackResponse:
prompts_arg: List[Dict[str, str]] = []
for prompt in prompts:
if isinstance(prompt, str):
Expand All @@ -31,4 +35,5 @@ def __call__(self, prompts: List[Union[str, Dict[str, str]]]) -> SlackResponse:
channel_id=self.channel_id,
thread_ts=self.thread_ts,
prompts=prompts_arg,
title=title,
)
3 changes: 3 additions & 0 deletions tests/scenario_tests/test_events_assistant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ def start_thread(say: Say, set_suggested_prompts: SetSuggestedPrompts, context:
assert context.thread_ts == "1726133698.626339"
say("Hi, how can I help you today?")
set_suggested_prompts(prompts=[{"title": "What does SLACK stand for?", "message": "What does SLACK stand for?"}])
set_suggested_prompts(
prompts=[{"title": "What does SLACK stand for?", "message": "What does SLACK stand for?"}], title="foo"
)
state["called"] = True

@assistant.thread_context_changed
Expand Down
4 changes: 4 additions & 0 deletions tests/scenario_tests_async/test_events_assistant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ async def start_thread(say: AsyncSay, set_suggested_prompts: AsyncSetSuggestedPr
await set_suggested_prompts(
prompts=[{"title": "What does SLACK stand for?", "message": "What does SLACK stand for?"}]
)
await set_suggested_prompts(
prompts=[{"title": "What does SLACK stand for?", "message": "What does SLACK stand for?"}],
title="foo",
)
state["called"] = True

@assistant.thread_context_changed
Expand Down