Skip to content

Conversation

@SheheryarAamir
Copy link

  • Replace com.vaadin.external.google with org.json
  • Replace JSONArray null with JSONObject.NULL
  • Fix testAssertEqualsString2JsonComparator actual json due to having duplicate keys ("id") in the same object. JSON objects must have unique keys

@carterpage
Copy link
Member

Thanks for your submission. This should be address in #194.

A few more things were needed to make the change, including handling the change of JSONException to a RuntimeException.

@carterpage carterpage closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants