Ensure full array comparison test ignores order #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing under [NonDex](https://github.com/TestingResearchIllinois/NonDex) because it relied on a specific order of comparison results; this PR alters it to accept any order of the results so long as all the expected ones are present. (As a bonus, the regex now looks a bit cleaner.)
Member
|
Makes sense, but need a way to test before and after. NonDex doesn't seem to want to run on anything but Java 8, so that would make the builds a little flaky. Open to suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing under NonDex because it relied on a specific order of comparison results; this PR alters it to accept any order of the results so long as all the expected ones are present. (As a bonus, the regex now looks a bit cleaner.)