Cache hashes#39
Closed
NicolasDorier wants to merge 28 commits into
Closed
Conversation
Author
|
Moving #36 |
b6cee44 to
e7343a9
Compare
7ae0189 to
82f323e
Compare
e7343a9 to
e625107
Compare
a660ed1 to
37973bf
Compare
e625107 to
2817523
Compare
Contains refactorings by Eric Lombrozo. Contains fixup by Nicolas Dorier.
Includes simplifications by Eric Lombrozo.
Rebased by Pieter Wuille. Cleanup by Matt Corallo.
Includes support for pushkeyhash wit v0 by Alex Morcos.
Includes fixup by Suhas Daftuar.
Includes fixup by Thomas Kerin.
…en verify_script receives VERIFY_WITNESS flag script_tests: always test bitcoinconsensus_verify_script_with_amount if VERIFY_WITNESS isn't set Rename internal method + make it static trim bitcoinconsensus_ prefix Add SERIALIZE_TRANSACTION_WITNESS flag
Witness blocks can be greater than 2MiB, but cannot be validly greater than 4MB.
2817523 to
7a98982
Compare
7a98982 to
26ec95f
Compare
909fb25 to
99c8d54
Compare
a88b686 to
38a8b36
Compare
Owner
|
As explained on IRC, this needs a more complicated approach that lets cache entries live longer than the CheckInputs call. |
Author
|
I will do it when I manage to get my hand on jetbrain Clion and PyCharm licenses. I'm concerned though that the test did not break, this should have triggered a segfault as I was accessing freed memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.