This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Lots of new detection and shiny things#76
Merged
Conversation
* Removed $isRobot, setIsRobot(), getIsRobot(), isRobot(), checkBrowserRobot() * Replaced above with detectScriptedAgent() * Added a new ScriptedAgent class with detection for bots, spiders, etc * Added isWebkit(), getIsWebkit(), setIsWebkit() NOTE: TODO: Should add proper browser engine detection (Webkit, Gecko, Trident, etc) * Added $isTwitterWebView, setIsTwitterWebView(), getIsTwitterWebView(), isTwitterWebView(); * Added browser detection for UC Browser * Added browser detection for NSPlayer (Windows Media Player) * Added OS detection for NSPlayer (Windows Media Player) * Added browser detection for Microsoft Office * Added browser detection for the Apple News app * Added browser detection for the Dalvik (Android) OS * Moved wkHTMLtoPDF to scripted agents and removed the test accordingly * Moved GoogleBot to scripted agents * Moved Slurp to scripted agents * Moved W3CValidator to scripted agents * Moved MSNBot to scripted agents * Renamed "Navigator" to "Android Navigator" for clarity * Strip linebreaks in setVersion (fixes a failng test) * Added .idea to the gitignore (I use PHPstorm, don't be a hater) TODO: Tests for new class
Member
|
Wow! This looks good. Give me a couple days to review everything and it should be good to merge! |
Instead of: Match everything except ^ ;\), Match: a-z, A-Z, 0-9, and . only. Remove dirty fudge added to remove the stray \n Now passes tests without said fudge
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! BREAKING CHANGES !!
Removed $isRobot, setIsRobot(), getIsRobot(), isRobot(), checkBrowserRobot()
Replaced above with detectScriptedAgent()
Added a new ScriptedAgent class with detection for bots, spiders, etc
Added isWebkit(), getIsWebkit(), setIsWebkit()
NOTE: TODO: Should add proper browser engine detection (Webkit, Gecko, Trident, etc)
Added $isTwitterWebView, setIsTwitterWebView(), getIsTwitterWebView(), isTwitterWebView();
Added browser detection for UC Browser
Added browser detection for NSPlayer (Windows Media Player)
Added OS detection for NSPlayer (Windows Media Player)
Added browser detection for Microsoft Office
Added browser detection for the Apple News app
Added browser detection for the Dalvik (Android) OS
Moved wkHTMLtoPDF to scripted agents and removed the test accordingly
Moved GoogleBot to scripted agents
Moved Slurp to scripted agents
Moved W3CValidator to scripted agents
Moved MSNBot to scripted agents
Renamed "Navigator" to "Android Navigator" for clarity
Strip linebreaks in setVersion (fixes a failng test)
Added .idea to the gitignore (I use PHPstorm, don't be a hater)
TODO: Tests for new class