Add Spawner options to enable admins to spawn user sessions#598
Merged
Conversation
… to re-create the options form
…, rather than manually navigating to JupyterHub home page
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
- Coverage 95.35% 95.03% -0.33%
==========================================
Files 92 93 +1
Lines 4305 4348 +43
Branches 422 429 +7
==========================================
+ Hits 4105 4132 +27
- Misses 140 156 +16
Partials 60 60
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #592
Makes use of JupyterHub's extendable spawner options form to provide admin users with the ability to spawn either "Admin" (
remoteappadmin) or "User" (remoteappmanager) sessions when they login.Notes
The existing session must be closed before the options form will be shown again. For JupyterHub < 1.0.0, the only way to do this is by navigating to
https://<simphony-remote>/hub/adminorhttps://<simphony-remote>/hub/homewhilst logged in and selecting the "Stop My Sever" option.Therefore (for now) we include the
SimphonyRemoteAuthMixinclass, providing a logout handler that automatically closes admin user servers upon a sign out. This has no effect on the functionality of the application since any Simphony-Remote applications will continue to run even if the JupyterHub server is shut down.For versions of JupyterHub >= 1.0.0, we can simply configure the
shutdown_on_logoutoption to do this instead.