Add version constraint to the docutils dependency#575
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 92 92
Lines 4305 4305
Branches 277 277
=======================================
Hits 4105 4105
Misses 140 140
Partials 60 60 Continue to review full report at Codecov.
|
flongford
reviewed
Nov 19, 2021
Contributor
There was a problem hiding this comment.
Thanks for spotting this @peterzahemszky - in order to catch any further regressions, could we include running make docs as part of our CI builds?
I think we only need to do so on one of the target OS (i.e. Ubuntu).
Scratch that - we already do it:
simphony-remote/.github/workflows/build_test_ubuntu18.yml
Lines 48 to 51 in fc5f0ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a version constraint to the docutils dependency to resolve problems with Sphinx.
Closes #574.