Skip to content

Discourage the use of Snap for installing Docker#573

Merged
peterzahemszky merged 2 commits into
masterfrom
572-discourage-snap
Nov 19, 2021
Merged

Discourage the use of Snap for installing Docker#573
peterzahemszky merged 2 commits into
masterfrom
572-discourage-snap

Conversation

@peterzahemszky

@peterzahemszky peterzahemszky commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

Discourage the use of Snap for installing Docker in the README, and hence close #572.

Update Docker installation URLs too

@peterzahemszky

Copy link
Copy Markdown
Contributor Author

I can reproduce the CI failure locally, both on this branch and on master. It's unrelated to this PR, so issue #574 is opened to track the problem separately

Comment thread README.rst Outdated
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #573 (a0940b4) into master (fc5f0ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          92       92           
  Lines        4305     4305           
  Branches      277      277           
=======================================
  Hits         4105     4105           
  Misses        140      140           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5f0ae...a0940b4. Read the comment docs.

@flongford flongford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterzahemszky peterzahemszky merged commit cb213fc into master Nov 19, 2021
@peterzahemszky peterzahemszky deleted the 572-discourage-snap branch November 19, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sudo service docker start can result in error "Failed to start docker.service: Unit docker.service not found."

3 participants