Fix User demo application assignment#569
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 95.16% 95.35% +0.18%
==========================================
Files 92 92
Lines 4222 4305 +83
Branches 271 277 +6
==========================================
+ Hits 4018 4105 +87
+ Misses 144 140 -4
Partials 60 60
Continue to review full report at Codecov.
|
…fig class, rather than User and BaseApplication classes
robertopreste
approved these changes
Sep 7, 2021
robertopreste
left a comment
Contributor
There was a problem hiding this comment.
Looks very good, thanks for the changes!
| if application.image in user.demo_applications: | ||
| self.log.info(application.image) | ||
| if application.image in self.file_config.demo_applications: | ||
| self.log.debug(f"Avaliable image: {application.image}") |
Contributor
There was a problem hiding this comment.
Just a small typo here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes and enhancements required to allow a set of demo applications provided to all new users to be declared in the
jupyterhub/remoteappmanager_config.py.This is achieved by introducing two features:
FileConfig.demo_applicationscan be configured with a list of image names that are already registered with the applicationFileConfig.auto_user_creationcan be configured to allow automatic registration of any authenticated user. If set toTrue, as long as the user can login via the declaredc.JupyterHub.authenticator_class, then an account will be automatically created in the Simphony-Remote database. Otherwise an admin user will have to manually perform the taskExamples of how these may be assigned are given in
jupyterhub/remoteappmanager_config.py