Extend remoteapprest to add startupdata option#566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 95.16% 95.21% +0.04%
==========================================
Files 92 92
Lines 4222 4261 +39
Branches 271 273 +2
==========================================
+ Hits 4018 4057 +39
Misses 144 144
Partials 60 60
Continue to review full report at Codecov.
|
flongford
left a comment
There was a problem hiding this comment.
Overall looks good, thanks @robertopreste - just a couple of comments
|
@flongford I fixed this, so that now the CLI would first check the |
Closes #565
The
remoteapprest app startCLI command now accept a--startupdataoption to provide a file path that will be loaded at startup.Note: the URL returned by the
remoteapprest app startcommand cannot be used to open the container yet; there are two issues with it:/api/v1/that needs to be removedThe correct URL is the one printed in the logs; working on a way to return it through
remoteapprest.