Skip to content

Rename srdata configurable class tag to startupdata#564

Merged
robertopreste merged 2 commits into
masterfrom
563-rename-srdata-tag
Sep 1, 2021
Merged

Rename srdata configurable class tag to startupdata#564
robertopreste merged 2 commits into
masterfrom
563-rename-srdata-tag

Conversation

@robertopreste

Copy link
Copy Markdown
Contributor

Closes #563

@flongford flongford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertopreste

Copy link
Copy Markdown
Contributor Author

Nit: I found one remaining srdata in the documentation:
https://github.com/simphony/simphony-remote/blob/563-rename-srdata-tag/doc/source/developer/docker.rst

Right, thanks for spotting this!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #564 (fce7d1c) into master (46312a0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fce7d1c differs from pull request most recent head d17fef5. Consider uploading reports for the commit d17fef5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          92       92           
  Lines        4222     4222           
  Branches      271      271           
=======================================
  Hits         4018     4018           
  Misses        144      144           
  Partials       60       60           
Impacted Files Coverage Δ
...eappmanager/tests/mocking/virtual/docker_client.py 93.04% <ø> (ø)
remoteappmanager/docker/configurables.py 97.29% <100.00%> (ø)
...emoteappmanager/docker/tests/test_configurables.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46312a0...d17fef5. Read the comment docs.

@flongford flongford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess the last change will need to be to the Paraview-SR repo?

@robertopreste

Copy link
Copy Markdown
Contributor Author

LGTM! I guess the last change will need to be to the Paraview-SR repo?

Exactly, I've already opened a merge request there.

@robertopreste robertopreste merged commit 9ad2c6f into master Sep 1, 2021
@robertopreste robertopreste deleted the 563-rename-srdata-tag branch September 1, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename srdata configurable class tag for consistency

3 participants