Add build matrix with CentOS to GH Actions#558
Merged
Conversation
added 7 commits
July 30, 2021 09:20
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 92 92
Lines 4168 4168
Branches 269 269
=======================================
Hits 3964 3964
Misses 144 144
Partials 60 60 Continue to review full report at Codecov.
|
flongford
reviewed
Aug 3, 2021
flongford
left a comment
Contributor
There was a problem hiding this comment.
Thanks @robertopreste! I only have a few minor comments, can re-review whenever
added 2 commits
August 3, 2021 10:59
This was referenced Aug 4, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #557
This PR adds a second workflow that targets CentOS 7, only installing Symphony Remote on this platform. Tests are run separately in the Ubuntu workflow.