Skip to content

MAINT: Update JupyterHub to v0.8.1#552

Merged
flongford merged 69 commits into
masterfrom
maint/update-jupyterhub
May 25, 2022
Merged

MAINT: Update JupyterHub to v0.8.1#552
flongford merged 69 commits into
masterfrom
maint/update-jupyterhub

Conversation

@flongford

@flongford flongford commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

Closes #397
Closes #596

This PR bumps the pinned version of jupyterhub to release 0.8.1

Changelog for 0.8.x series of JupyterHub: https://jupyterhub.readthedocs.io/en/stable/changelog.html#id44

Commit comparison between 0.8.1 and current pinned commit on master: jupyterhub/jupyterhub@2d1a45f...0.8.1

Major changes include:

  • Replacing jupyterhub.orm.Proxy with jupyterhub.proxy.Proxy where appropriate
  • Replacing jupyterhub.orm.Hub with jupyterhub.objects.Hub where appropriate
  • Updating handling of BaseApplication settings between CommandLineConfig and EnvironmentConfig
  • Adding a jupyterhub versioning check to the BaseApplication class (may not be required)
  • Authenticating with JupyterHub as an OAuth provider, rather than using (deprecated) session cookie

@flongford flongford marked this pull request as draft July 13, 2021 14:47
Comment thread remoteappmanager/services/reverse_proxy.py Outdated
Comment thread remoteappmanager/jupyterhub/spawners.py Outdated
Comment thread nginx/nginx.conf.template Outdated
Comment thread remoteappmanager/base_application.py Outdated
Comment thread remoteappmanager/handlers/handler_authenticator.py Outdated
@codecov-commenter

codecov-commenter commented May 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #552 (b6c7ebc) into master (5cc033c) will decrease coverage by 0.24%.
The diff coverage is 86.01%.

❗ Current head b6c7ebc differs from pull request most recent head da197ae. Consider uploading reports for the commit da197ae to get more accurate results

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   95.03%   94.79%   -0.25%     
==========================================
  Files          93       93              
  Lines        4350     4418      +68     
  Branches      429      432       +3     
==========================================
+ Hits         4134     4188      +54     
- Misses        156      168      +12     
- Partials       60       62       +2     
Impacted Files Coverage Δ
remoteappmanager/command_line_config.py 100.00% <ø> (ø)
...ager/jupyterhub/auth/simphony_remote_auth_mixin.py 38.09% <20.00%> (+3.09%) ⬆️
remoteappmanager/tests/mocking/dummy.py 91.76% <33.33%> (+0.09%) ⬆️
remoteappmanager/base_application.py 88.63% <67.56%> (-8.34%) ⬇️
remoteappmanager/jupyterhub/spawners.py 87.87% <87.50%> (-0.67%) ⬇️
remoteappmanager/services/hub.py 97.05% <88.88%> (-2.95%) ⬇️
remoteappmanager/environment_config.py 100.00% <100.00%> (ø)
...anager/handlers/admin/tests/test_admin_handlers.py 100.00% <100.00%> (ø)
remoteappmanager/handlers/base_handler.py 97.05% <100.00%> (+0.39%) ⬆️
remoteappmanager/handlers/handler_authenticator.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc033c...da197ae. Read the comment docs.

@flongford flongford marked this pull request as ready for review May 25, 2022 15:52
@flongford flongford merged commit c0acbfb into master May 25, 2022
@flongford flongford deleted the maint/update-jupyterhub branch May 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't rely on insecure cookies from JupyterHub to verify users Tests not passing against jupyterhub master

2 participants