Bump requests from 2.10.0 to 2.20.0

[dependabot]

Bumps requests from 2.10.0 to 2.20.0.

Changelog

Sourced from requests's changelog.

2.20.0 (2018-10-18)

Bugfixes

• Content-Type header parsing is now case-insensitive (e.g. charset=utf8 v Charset=utf8).
• Fixed exception leak where certain redirect urls would raise uncaught urllib3 exceptions.
• Requests removes Authorization header from requests redirected from https to http on the same hostname. (CVE-2018-18074)
• should_bypass_proxies now handles URIs without hostnames (e.g. files).

Dependencies

• Requests now supports urllib3 v1.24.

Deprecations

• Requests has officially stopped support for Python 2.6.

2.19.1 (2018-06-14)

Bugfixes

• Fixed issue where status_codes.py's init function failed trying to append to a __doc__ value of None.

2.19.0 (2018-06-12)

Improvements

• Warn user about possible slowdown when using cryptography version < 1.3.4
• Check for invalid host in proxy URL, before forwarding request to adapter.
• Fragments are now properly maintained across redirects. (RFC7231 7.1.2)
• Removed use of cgi module to expedite library load time.
• Added support for SHA-256 and SHA-512 digest auth algorithms.
• Minor performance improvement to Request.content.
• Migrate to using collections.abc for 3.7 compatibility.

Bugfixes

• Parsing empty Link headers with parse_header_links() no longer return one bogus entry.

Commits

• bd84045 v2.20.0
• 7fd9267 remove final remnants from 2.6
• 6ae8a21 Add myself to AUTHORS
• 89ab030 Use comprehensions whenever possible
• 2c6a842 Merge pull request #4827 from webmaven/patch-1
• 30be889 CVE URLs update: www sub-subdomain no longer valid
• a6cd380 Merge pull request #4765 from requests/encapsulate_urllib3_exc
• bbdbcc8 wrap url parsing exceptions from urllib3's PoolManager
• ff0c325 Merge pull request #4805 from jdufresne/https
• b0ad249 Prefer https:// for URLs throughout project
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

[codecov-commenter]

Codecov Report

Merging #547 (81fb96c) into master (9081860) will not change coverage.
The diff coverage is n/a.

❗ Current head 81fb96c differs from pull request most recent head fb0000b. Consider uploading reports for the commit fb0000b to get more accurate results

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files          93       93           
  Lines        4418     4418           
  Branches      432      432           
=======================================
  Hits         4188     4188           
  Misses        168      168           
  Partials       62       62           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada647d...fb0000b. Read the comment docs.

[peterzahemszky]

Let's re-run CI and see how this update would affect the codebase

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

[peterzahemszky]

Given that the upgrade is a change to the "minor" component of the version, I think it's safe to apply the change suggested here.

The direct usages of the requests package in our production code are fairly well defined: they're either in remoteappmanager/cli/remoteapprest/__main__.py or in remoteappmanager/cli/remoteappdb/__main__.py. The uses of requests in those two files are

• requests.exceptions.ConnectionError,
• requests.post(),
• requests.utils.dict_from_cookiejar(),
• requests.get(),
• requests.delete(),
• requests.packages.urllib3.exceptions.InsecureRequestWarning and
• requests.packages.urllib3.disable_warnings().

We should look at the change log between versions 2.10.0 and 2.20.0 and see if those objects were affected in a backward incompatible way.

Of course there could be indirect usages, e.g. a dependency using requests, but ideally we can assume that they declare their version constraints as necessary.

Continuous integration is passing, which is a good sign. However, we should do manual testing if there are requests-related parts of the codebase that are not covered sufficiently well by automated tests.

[dependabot]

Looks like requests is up-to-date now, so this is no longer needed.