Skip to content

FEAT: Update Simphony-Remote repo with latest development (2.2.0.dev)#544

Merged
flongford merged 44 commits into
masterfrom
feat/update-sr
Jul 16, 2020
Merged

FEAT: Update Simphony-Remote repo with latest development (2.2.0.dev)#544
flongford merged 44 commits into
masterfrom
feat/update-sr

Conversation

@flongford

@flongford flongford commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

This PR updates the repository with developments from the Simphony-3 group.

New features:

  • Inclusion of (optional) license key in ApplicationPolicy object
  • Inclusion of Nginx template scripts for setting up a reverse proxy
  • Inclusion of BasicAuthenticator class for simple demo deployments
  • Supports additional OAuth services using oauthenticator package

Updates:

  • Updated Makefile with supported Ubuntu 18.0.4 and CentOS7 build
  • Updated tornado package to version 5.1.1
  • Updated dependency versions (now install astor through PyPi)
  • Updated documentation

Removals

  • Replace deprecated tornado.testing.LogTrapTestCase test case class with ExpectLog
  • Remove AsyncTestCase patch for older versions of tornado.testing

Maintenance

  • Docker compose scripts included to build SR docker image for debug purposes
  • Included geckodriver installation for selenium testing
  • TravisCI build now uses Ubuntu 18.04 and Firefox 75.0

@flongford

Copy link
Copy Markdown
Contributor Author

Currently debugging unit tests for Container class - there seems to have been a change in expected behavior of the remoteappmanager.webapi.tests.test_container methods.

This may be coming from differences in the mock_coro_new_callable and mock_coro_factory functions in the remoteappmanager.tests.utils module

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #544 into master will increase coverage by 0.08%.
The diff coverage is 95.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   95.18%   95.26%   +0.08%     
==========================================
  Files          85       86       +1     
  Lines        3905     4015     +110     
  Branches      247      252       +5     
==========================================
+ Hits         3717     3825     +108     
+ Misses        137      136       -1     
- Partials       51       54       +3     
Impacted Files Coverage Δ
remoteappmanager/handlers/base_handler.py 96.66% <ø> (-0.11%) ⬇️
remoteappmanager/tests/utils.py 90.74% <ø> (+9.38%) ⬆️
remoteappmanager/webapi/tests/test_application.py 100.00% <ø> (ø)
remoteappmanager/webapi/container.py 82.83% <33.33%> (-0.75%) ⬇️
remoteappmanager/base_application.py 92.13% <54.54%> (-5.34%) ⬇️
...eappmanager/jupyterhub/auth/basic_authenticator.py 86.66% <86.66%> (ø)
remoteappmanager/cli/tests/test_remoteappdb.py 100.00% <100.00%> (ø)
remoteappmanager/command_line_config.py 100.00% <100.00%> (ø)
remoteappmanager/db/csv_db.py 98.76% <100.00%> (+0.01%) ⬆️
remoteappmanager/db/interfaces.py 100.00% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba40e38...05e9b7a. Read the comment docs.

@flongford flongford merged commit 15d2aeb into master Jul 16, 2020
@flongford flongford deleted the feat/update-sr branch July 16, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants